From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19468: 25.0.50; UI inconveniences with M-. Date: Tue, 28 Apr 2015 01:25:14 +0300 Message-ID: <553EB74A.4030208@yandex.ru> References: <83zja6b3tc.fsf@gnu.org> <54A24079.4020902@yandex.ru> <54A2FF47.6010207@yandex.ru> <54A86135.7080004@yandex.ru> <54A90002.7080009@gmx.at> <54A9C3FB.7000602@yandex.ru> <54AA3881.3080304@gmx.at> <54ABBB47.7010603@yandex.ru> <837fszx7iy.fsf@gnu.org> <83pp6pwqnw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1430173583 18126 80.91.229.3 (27 Apr 2015 22:26:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Apr 2015 22:26:23 +0000 (UTC) Cc: 19468@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 28 00:26:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YmrTd-0007G8-9k for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Apr 2015 00:26:09 +0200 Original-Received: from localhost ([::1]:57906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmrTc-0003jp-NQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Apr 2015 18:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmrTZ-0003jj-P0 for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 18:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmrTW-0005G6-HO for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 18:26:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmrTW-0005G2-EK for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 18:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YmrTW-0006d3-4z for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 18:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 22:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19468-submit@debbugs.gnu.org id=B19468.143017352625440 (code B ref 19468); Mon, 27 Apr 2015 22:26:02 +0000 Original-Received: (at 19468) by debbugs.gnu.org; 27 Apr 2015 22:25:26 +0000 Original-Received: from localhost ([127.0.0.1]:41678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmrSt-0006cE-Up for submit@debbugs.gnu.org; Mon, 27 Apr 2015 18:25:25 -0400 Original-Received: from mail-wi0-f175.google.com ([209.85.212.175]:36638) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmrSs-0006bz-6h for 19468@debbugs.gnu.org; Mon, 27 Apr 2015 18:25:22 -0400 Original-Received: by wizk4 with SMTP id k4so117327543wiz.1 for <19468@debbugs.gnu.org>; Mon, 27 Apr 2015 15:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=UfONkjZ8M8vcShbr8/TM/omO/hNlvi79GUxVgqRy22w=; b=afmB0xTaKYnm80ycf3v/m8QmlCh16sGF/DQRYAd7fojS1lcCWo1RaAha2JXKHRpIIi UmpLi2Wz7uqNkNoqrnEvJyXJghTj4D0aPqBQzhKkh/exzjwqvc5oDHAv9TqzA0/u6rEC L83izATnLnSLKiaSXIXdMmWp4/gU4qD3iZEddtE01O6RDsW3GGCn5il5ZL2UWCG9CTt9 1iD5FbeA7/dLWLSeDe8IdgfmbhMJ5n+7Qo0eX0qKcGW3NyAqfOHj5VKHGjPEHQpUiAlb VOjCa/u1TJIDNVcdDpw9wj5sgVUu/0Cgk2/FBTjCAj8+/Lxndu53+LYDbtMvfdXe5bO2 RQWg== X-Received: by 10.194.62.83 with SMTP id w19mr27042734wjr.40.1430173516639; Mon, 27 Apr 2015 15:25:16 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id wo10sm31271413wjb.35.2015.04.27.15.25.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 15:25:16 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102125 Archived-At: On 04/27/2015 08:21 PM, Stefan Monnier wrote: > The different ways to call xref-find-function are to distinguish > jumping to the definition or to "all uses", and currently few backends > support those features, I don't think we have a clear idea yet of how > they should be presented to the user, and there are too many variants to > collapse them all into C-u. So they'd probably be provided via > different commands instead of all being accessed via M-. M-x xref-find-references, for starters. > - (setq-local xref-find-function #'elisp-xref-find) > - (setq-local xref-identifier-completion-table-function > - #'elisp--xref-identifier-completion-table) > + (add-function :before-until (local 'xref-find-function) #'elisp-xref-find) > + (add-function :before-until (local 'xref-identifier-completion-table-function) > + #'elisp--xref-identifier-completion-table) This doesn't look right: - When I try to jump to a symbol, and there isn't one with that name, I want to see the message "no definitions found", not a "Visit tags table" prompt. - If I do have a tags table loaded, it's likely for a different project than Emacs. This is most likely true for the majority of our users. I think Eli (and everyone like-minded) should advise elisp-xref-find and xref-identifier-completion-table-function instead, inside their init script, like suggested by Daniel in another thread.