From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20322: 25.0.50; indent-tabs-mode should default to nil Date: Wed, 15 Apr 2015 05:08:22 +0300 Message-ID: <552DC816.3030002@yandex.ru> References: <861tjn3069.fsf@yandex.ru> <552D20B6.8030005@yandex.ru> <83mw2abul3.fsf@gnu.org> <552D34BC.4090806@yandex.ru> <83h9sibt0q.fsf@gnu.org> <552D7796.2090109@yandex.ru> <552D9204.3000604@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1429063762 7367 80.91.229.3 (15 Apr 2015 02:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Apr 2015 02:09:22 +0000 (UTC) Cc: 20322@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 15 04:09:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YiClK-0007vC-Cy for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Apr 2015 04:09:10 +0200 Original-Received: from localhost ([::1]:58507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiClJ-0008A5-O0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2015 22:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiClG-0008A0-9I for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 22:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiClC-0008JZ-VT for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 22:09:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiClC-0008JU-R3 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 22:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YiClC-0004Ms-4t for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 22:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20322-submit@debbugs.gnu.org id=B20322.142906371416731 (code B ref 20322); Wed, 15 Apr 2015 02:09:02 +0000 Original-Received: (at 20322) by debbugs.gnu.org; 15 Apr 2015 02:08:34 +0000 Original-Received: from localhost ([127.0.0.1]:56539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiCkj-0004Ln-Rj for submit@debbugs.gnu.org; Tue, 14 Apr 2015 22:08:34 -0400 Original-Received: from mail-wi0-f179.google.com ([209.85.212.179]:37122) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiCkh-0004LR-Fu for 20322@debbugs.gnu.org; Tue, 14 Apr 2015 22:08:32 -0400 Original-Received: by widdi4 with SMTP id di4so43205169wid.0 for <20322@debbugs.gnu.org>; Tue, 14 Apr 2015 19:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=aMeHR2xO3/qWVQL2THUhbu0yQSpd92MJ0IJ12bKlvOI=; b=m9BvKECjZ4qi/K537XwbxxWkOdOzNGy4IgqX/Tb96/sSkQSSK2g82LOi0UdjEvT8Dp R2cxmpJHVfJj5o+xijCvno++VFLPmf1VFxHjIJFPmRLYAHWfVyutzeQxgSlpFDbGu+cL 97wh5qXbM24+/F0C2e6KP214zb8WOOG/2TdwAcugcDPfly1pWS2SUZFBMzOEmot5CMfg dA4wjC2Ktz0YyasFR1fqQ7cZqj9yLCBxw5ye7MOGc9CRzzrMYatUPdnty90AdK+OEmGa mh4nHmZQyZDgTBy4d2lTpk5BiC0yXV2Tto/C4g+KMQwkLPFkdqwb73rdZHwUkBd8wchP sQuw== X-Received: by 10.194.94.164 with SMTP id dd4mr45472421wjb.56.1429063705926; Tue, 14 Apr 2015 19:08:25 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id n8sm5075997wiy.19.2015.04.14.19.08.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 19:08:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101544 Archived-At: On 04/15/2015 04:19 AM, Stefan Monnier wrote: >> However, the implementation seems to do the right thing: > >> https://github.com/outsideris/popularconvention/blob/master/src/parser/js-parser.coffee#L99-L100 > > This seems to count the number of lines which start with a SPC and those > which start with a TAB. That sounds right. But I'd say the projects that mix tabs and spaces must be a minority among those that use tabs at all. > If your indentation rules use an indentation step of 2, you'd likely get > many more lines that start with SPC regardless of indent-tabs-mode > (just because most lines of code are less indented than 8 columns). I don't actually recall seeing code intentionally mixing tabs and spaces like that, ever, before looking at Emacs's sources. > So, I don't think it does the right test. I think the right test would be > > tab = /^\t/ > space = /^\s\s\s\s\s\s\s\s/ That would be more correct indeed. Again, if you think the results of this can matter in some future decision, I can spend the time to apply the fix, deploy it myself and rerun the analysis.