From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Date: Mon, 14 Feb 2022 19:18:53 +0100 Message-ID: <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> <87bkz9co1d.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53897@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 14 19:20:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJfxK-00052c-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Feb 2022 19:20:10 +0100 Original-Received: from localhost ([::1]:42942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJfxJ-00035O-6r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Feb 2022 13:20:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJfxC-00035D-EC for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJfxC-0000WM-4k for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJfxC-0002Dk-1r for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Feb 2022 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53897 X-GNU-PR-Package: emacs Original-Received: via spool by 53897-submit@debbugs.gnu.org id=B53897.16448627468463 (code B ref 53897); Mon, 14 Feb 2022 18:20:01 +0000 Original-Received: (at 53897) by debbugs.gnu.org; 14 Feb 2022 18:19:06 +0000 Original-Received: from localhost ([127.0.0.1]:42519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfwI-0002CQ-DC for submit@debbugs.gnu.org; Mon, 14 Feb 2022 13:19:06 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:51337 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJfwE-0002Bp-EN for 53897@debbugs.gnu.org; Mon, 14 Feb 2022 13:19:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d0IMEyT/H6QDzU5caFjj8cepTF8S7nklvYsQRY4dTAQ=; b=v2wGFGPKYYQHe4Jjz4sIoMtu02 z9WIPdp7huxst4G9tcveFQBtqz9J795O6IA6RsGvJMaiOHBmDKUuzScyK1WDHdeaF/eXboK6LuiFp NBUieJ0oFvLmDzxJcORPCJ5+xrKYsoh42X4UMajboUeNcNCCaP0DvfGcBM7pNVAbJpSA=; Content-Language: en-US In-Reply-To: <87bkz9co1d.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226913 Archived-At: >>> I could imagine introducing a user option to decide what you want to >>> use. My inclination would be to set it to "cycle by default", but it >>> doesn't need that way. Perhaps we could test non-cycling (regular capf) >>> for a while, and see if there are any complaints or other feedback? >> >> Yes, I would go with normal Capf behavior, which is the usual behavior >> across all of Emacs. If a user wants to restore rcirc-complete, it seems >> easy enough to add this to a user configuration? >> >> (defun rcirc-complete () >> (interactive) >> (let ((completion-cycle-threshold t)) >> (completion-at-point))) > > Or, this could be added as rcirc-complete, binding TAB back to this new > command and documenting that if you want to complete using the default > CAPF, you should rebind it to completion-at-point? That's an option too. But then you will still keep the old cruft around. I would rather break backward compatibility here and document that binding `completion-cycle-threshold=t` will restore the old behavior. Most users will appreciate that a Capf is directly available, which is more capable than `rcirc-complete`! Daniel