From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Date: Mon, 2 May 2022 11:57:44 +0200 Message-ID: <552469c2-d4d3-3caa-016a-a454f3e53779@daniel-mendler.de> References: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> <87wnf5mpt4.fsf@gnus.org> <87k0b5duzh.fsf@gnus.org> <8735htdrmt.fsf@gnus.org> <87o80g486l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 55205@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 02 11:58:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlSp0-0001oA-A5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 May 2022 11:58:26 +0200 Original-Received: from localhost ([::1]:37154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlSoz-0001tc-CX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 May 2022 05:58:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlSob-0001tF-Th for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 05:58:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlSob-0001Yw-L8 for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 05:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nlSob-0002iW-JV for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 05:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 May 2022 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55205 X-GNU-PR-Package: emacs Original-Received: via spool by 55205-submit@debbugs.gnu.org id=B55205.165148547410429 (code B ref 55205); Mon, 02 May 2022 09:58:01 +0000 Original-Received: (at 55205) by debbugs.gnu.org; 2 May 2022 09:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:34910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlSoU-0002i9-H5 for submit@debbugs.gnu.org; Mon, 02 May 2022 05:57:54 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:50071 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlSoT-0002ht-6H for 55205@debbugs.gnu.org; Mon, 02 May 2022 05:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BSbbCryhCHcY/zCRQ3nbyC8TkC18n3tKhOgrcUSzRoM=; b=VuTfHDcWotuP5mo7bH6LtrqWZ0 2amzAKr3qKhGVOGvvJMjxE9/GOZdVHPtmDbvd9zfdbuyhm2khWn1z6RjTU9CBKfv5+7902tzXVoa0 TlRNoBbUYLSYuFjlN8+hSvgLk6q3YZQerrbWRJZAoVlPThqhdBeWI6uZeWljwdHal9HI=; Content-Language: en-US In-Reply-To: <87o80g486l.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231248 Archived-At: On 5/2/22 11:04, Lars Ingebrigtsen wrote: > Daniel Mendler writes: > >> But again, since Lars asked this - text properties are not stripped, >> they never materialize in the first place due to completion just being a >> form of user input. (Technically they are stripped, but only to >> normalize the resulting input in case some text properties make it through.) > > I only want to keep the text properties when doing selection -- when the > user types something without selecting a candidate, then there are no > text properties to speak of. Okay, but that's not a good idea since then the return value of completing-read will differ depending on the way the user performed selection or completion. The caller of completing-read will have to handle return values without text properties anyway so nothing is won by returning strings with text properties only *sometimes*. The more conservative approach is then to never return strings with text properties as completing-read does currently. Daniel