From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Mon, 21 Oct 2024 21:08:37 +0100 Message-ID: <5514e870-3766-4070-838a-e92495c1da55@yandex.ru> References: <874j59wym3.fsf@melete.silentflame.com> <868qukl73k.fsf@gnu.org> <87bjzfuzaq.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36136"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Morgan.J.Smith@outlook.com, 64055@debbugs.gnu.org To: Sean Whitton , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 21 22:09:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2yiy-0009D0-N0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Oct 2024 22:09:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2yih-0006H7-Br; Mon, 21 Oct 2024 16:09:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2yie-0006Gk-6O for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2024 16:09:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2yid-0003p6-To for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2024 16:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=zpEoMgG+b8mFegRxA9hWyXhgQiQHPqcsFed8wLUO0rU=; b=tOiQwRxYhDp/9t7CoWZuGi/ALAztX/UWdVM+RRkRGnAd+tzbrv8S3twAiJi1gX2+U+BUFsSJiKvv7IifeZSBrvW6s/7r815Kzq+gSSR4QW+ppNn4Df8DNwr1y7j5lsjrn7jJkQeeOo4UnLn5iwNDl5K/9em/57/J0UaqEP5emBn0/srugZjI7rbx7jzZEZWxVlMs3exFASzjaEHziCQPbvAz0HiVCm1QPatpUpYcRHttULU4cIvpJft6G2YqwxkkzyY4cN1bubf0vrOI2/GA2a1wmvYAzWXArloxIzmTE4uf8zGalGv6PH4ru8Rrrtkf0plKi2XA8SK03JT6yXLm+w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2yj3-0003Yc-Pi for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2024 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2024 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172954138713644 (code B ref 64055); Mon, 21 Oct 2024 20:10:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 21 Oct 2024 20:09:47 +0000 Original-Received: from localhost ([127.0.0.1]:53428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2yio-0003Xz-WE for submit@debbugs.gnu.org; Mon, 21 Oct 2024 16:09:47 -0400 Original-Received: from forward502a.mail.yandex.net ([178.154.239.82]:53816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2yim-0003Xp-1C for 64055@debbugs.gnu.org; Mon, 21 Oct 2024 16:09:45 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net [IPv6:2a02:6b8:c15:2b05:0:640:2a62:0]) by forward502a.mail.yandex.net (Yandex) with ESMTPS id 0F4E0613D6; Mon, 21 Oct 2024 23:08:46 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id h8YbKA3b2mI0-qbSP84yf; Mon, 21 Oct 2024 23:08:45 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1729541325; bh=zpEoMgG+b8mFegRxA9hWyXhgQiQHPqcsFed8wLUO0rU=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=Jekv0ibWN4LxqEmqUGttipydyJuOzN8WOTRq284oQmjvN940IP2IDjxdBTq//8Jqj zlhw8XEH5b/pffp48gGfs909hRT+vfcE4uGuWUUVqHCB5ROhCeu6mh0/KSoxEsrbet mrMfvhKqKvE2vBBoOMcYbnBSU4ae0+a7i0wUeTu4= Authentication-Results: mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfauth.phl.internal (Postfix) with ESMTP id D85D3120006D; Mon, 21 Oct 2024 16:08:42 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Mon, 21 Oct 2024 16:08:42 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughguhhtohhvseihrghnuggvgi drrhhuqeenucggtffrrghtthgvrhhnpeeihfejueevteffffdvfeetffffkefhuedujeei heehiedulefghefgffefudffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegughhuthhovhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqudeffeefleelheehvddqvdelgeejjeejjeeiqdgughhuthhovheppeihrghnug gvgidrrhhusehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthhtohepgedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepshhpfihhihhtthhonhesshhpfihhihhtthhonh drnhgrmhgvpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhho rhhgrghnrdhjrdhsmh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 16:08:40 -0400 (EDT) Content-Language: en-US In-Reply-To: <87bjzfuzaq.fsf@melete.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294084 Archived-At: On 20/10/2024 08:19, Sean Whitton wrote: > + (nothing-staged > + (zerop > + (vc-git-command nil t nil "diff" "--cached" "--quiet")))) Testing it a little more, this seems insufficient because rebase aborts on non-staged changes too. This seems to cover both cases: (no-changes (zerop (vc-git-command nil t nil "diff" "HEAD" "--quiet")))) Regarding the command's latency it seems to be distributed like this in my current example: allowed rewrite? Elapsed time: 0.028043s stash push maybe Elapsed time: 0.072001s rebase autosquash Elapsed time: 0.047211s stash pop Elapsed time: 0.032561s So all steps are somewhat expensive, but stashing is #1 in that. Overall it seems fine, not a problem for the interactive command.