From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#20206: 25.0.50; [PATCH] keep diff-mode's window visible when we visit sources from diff-mode Date: Thu, 26 Mar 2015 19:58:53 +0100 Message-ID: <551456ED.8060101@gmx.at> References: <87a8yzy5t4.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1427396424 31001 80.91.229.3 (26 Mar 2015 19:00:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Mar 2015 19:00:24 +0000 (UTC) To: Dima Kogan , 20206@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 26 20:00:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YbD0n-0001lj-85 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Mar 2015 20:00:13 +0100 Original-Received: from localhost ([::1]:46171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD0m-0005Em-Dv for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Mar 2015 15:00:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD0j-0005DP-6A for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 15:00:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbD0f-0000sy-Ui for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 15:00:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbD0f-0000sI-SH for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 15:00:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YbD0e-0001P5-E4 for bug-gnu-emacs@gnu.org; Thu, 26 Mar 2015 15:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Mar 2015 19:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20206-submit@debbugs.gnu.org id=B20206.14273963505310 (code B ref 20206); Thu, 26 Mar 2015 19:00:04 +0000 Original-Received: (at 20206) by debbugs.gnu.org; 26 Mar 2015 18:59:10 +0000 Original-Received: from localhost ([127.0.0.1]:37582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbCzl-0001NZ-Ei for submit@debbugs.gnu.org; Thu, 26 Mar 2015 14:59:09 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:53629) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbCzj-0001N2-3j for 20206@debbugs.gnu.org; Thu, 26 Mar 2015 14:59:07 -0400 Original-Received: from [62.47.140.183] ([62.47.140.183]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M08ia-1ZTB3l2kk0-00uHlf; Thu, 26 Mar 2015 19:58:57 +0100 In-Reply-To: <87a8yzy5t4.fsf@secretsauce.net> X-Provags-ID: V03:K0:MdnDvwhyokiBhoLteGg8Ql9ClR9bi5yzFBqJoXzHwiUdmItgopC DcFRZ1H5WUH7tdqRmftRSvqbmIlJc+6uKYdEH1QiZW9ddoXnX2JZSajkL/6OQrQkjIwZzRj w+zZKBCTM+8uslP56ZhQdfbrTWAnrdgFLDTG1zC+VVpXG/302gLzfu5mcNfFc5/EC57kjnF HSw3iApuacl5OykGFKa/g== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100962 Archived-At: > - (pop-to-buffer (current-buffer)) Something must be wrong here. According to its doc-string `pop-to-buffer' should "Select buffer BUFFER in some window, preferably a different one." But I nowhere see that it tries to enforce that. Am I blind? And `display-buffer' should not use the selected window either, after all it's likely the most recently used one. Could you please debug this in order to explain why the selected window gets used in all these cases? > + (pop-to-buffer (current-buffer) '(display-buffer-use-some-window (inhibit-same-window . t))) In any case `display-buffer-use-some-window' as sole action doesn't look right. It should be preceded by `display-buffer-reuse-window' and `display-buffer-pop-up-window'. And `pop-to-buffer' should do that already. Thanks, martin