unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20154@debbugs.gnu.org
Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings
Date: Sun, 22 Mar 2015 16:52:03 +0200	[thread overview]
Message-ID: <550ED713.2010201@yandex.ru> (raw)
In-Reply-To: <550DDE25.1090000@yandex.ru>

Here's the version I've arrived at:

(defun json-encode-string-3 (string)
   "Return a JSON representation of STRING."
   ;; Reimplement the meat of `replace-regexp-in-string', for
   ;; performance (bug#20154).
   (let ((l (length string))
         (start 0)
         (res (list "\"")))
     ;; Skip over ASCIIish printable characters.
     (while (string-match "[\"\\/\b\f\n\r\t]\\|[^ -~]" string start)
       (let* ((mb (match-beginning 0))
              (c (aref string mb))
              (special (rassoc c json-special-chars)))
         (push (substring string start mb) res)
         (push (if special
                   ;; Special JSON character (\n, \r, etc.).
                   (string ?\\ (car special))
                 ;; Fallback: UCS code point in \uNNNN form.
                 (format "\\u%04x" c))
               res)
         (setq start (1+ mb))))
     (push (substring string start l) res)
     (push "\"" res)
     (apply #'concat (nreverse res))))

A bit slower than the temp-buffer version (90ms vs 80ms), but 
consistently faster than the current version, even on small strings. 
Probably the best we can do in Lisp.

If no one has any better ideas, I'm going to install it.





  parent reply	other threads:[~2015-03-22 14:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 14:26 bug#20154: 25.0.50; json-encode-string is too slow for large strings Dmitry Gutov
2015-03-20 14:34 ` Eli Zaretskii
2015-03-20 14:43   ` Dmitry Gutov
2015-03-20 15:03     ` Eli Zaretskii
2015-03-20 15:20       ` Dmitry Gutov
2015-03-20 16:02         ` Eli Zaretskii
2015-03-20 16:21           ` Dmitry Gutov
2015-03-20 16:44             ` Eli Zaretskii
2015-03-20 16:52               ` Dmitry Gutov
2015-03-20 17:44                 ` Eli Zaretskii
2015-03-20 18:42                   ` Dmitry Gutov
2015-03-20 21:14                     ` Eli Zaretskii
2015-03-20 22:02                       ` Dmitry Gutov
2015-03-21  7:58                         ` Eli Zaretskii
2015-03-21  8:12                           ` Eli Zaretskii
2015-03-21 20:00                           ` Dmitry Gutov
2015-03-21 20:25                             ` Eli Zaretskii
2015-03-21 21:26                               ` Dmitry Gutov
2015-03-22 17:31                                 ` Eli Zaretskii
2015-03-22 18:13                                   ` Dmitry Gutov
2015-03-22 18:26                                   ` Dmitry Gutov
2015-03-22 18:32                                     ` Eli Zaretskii
2015-03-22 19:03                                       ` Dmitry Gutov
2015-03-21 21:05                             ` Drew Adams
2015-03-21 21:32                               ` Dmitry Gutov
2015-04-20 22:20                         ` Ted Zlatanov
2015-04-20 22:41                           ` Dmitry Gutov
2015-04-20 23:11                             ` Ted Zlatanov
2015-03-20 22:26                       ` Dmitry Gutov
2015-03-21  8:07                         ` Eli Zaretskii
2015-03-21 21:09                           ` Dmitry Gutov
2015-03-21 22:20                             ` Ivan Shmakov
2015-03-21 23:36                               ` Dmitry Gutov
2015-03-22 14:52                             ` Dmitry Gutov [this message]
2015-03-22 16:15                               ` Ivan Shmakov
2015-03-22 16:47                                 ` Dmitry Gutov
2015-03-22 17:43                                   ` Eli Zaretskii
2015-03-22 19:15                                   ` Ivan Shmakov
2015-03-22 16:51                                 ` Eli Zaretskii
2015-03-22 18:22                                 ` Glenn Morris
2015-03-22 16:50                               ` Eli Zaretskii
2015-03-22 17:10                                 ` Dmitry Gutov
2015-03-22 22:57           ` Dmitry Gutov
2015-03-23 15:37             ` Eli Zaretskii
2015-04-07 13:31               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550ED713.2010201@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=20154@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).