From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Fri, 20 Mar 2015 18:52:26 +0200 Message-ID: <550C504A.10708@yandex.ru> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> <83siczvcss.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1426870408 1339 80.91.229.3 (20 Mar 2015 16:53:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 16:53:28 +0000 (UTC) Cc: 20154@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 17:53:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZ0AZ-000659-5a for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 17:53:11 +0100 Original-Received: from localhost ([::1]:44816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0AY-00040e-Hu for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 12:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0AU-00040N-Bq for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ0AQ-0004pw-BA for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:53:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0AQ-0004ps-7i for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZ0AQ-0002Op-1x for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 12:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 16:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.14268703569189 (code B ref 20154); Fri, 20 Mar 2015 16:53:02 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 20 Mar 2015 16:52:36 +0000 Original-Received: from localhost ([127.0.0.1]:59334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ0A0-0002O9-Ao for submit@debbugs.gnu.org; Fri, 20 Mar 2015 12:52:36 -0400 Original-Received: from mail-wi0-f169.google.com ([209.85.212.169]:38787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ09x-0002Nw-RG for 20154@debbugs.gnu.org; Fri, 20 Mar 2015 12:52:34 -0400 Original-Received: by wibgn9 with SMTP id gn9so20017505wib.1 for <20154@debbugs.gnu.org>; Fri, 20 Mar 2015 09:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=59oqKGOUm+S/MhdLyzIA/UQKpPV3rQtkYpTgfWNxvnQ=; b=Mv+4ChQnsXSM2ZGQ8hrxo37WKSTia7vybye+9gpGJnswtlYIPTpPABaQZBZpXH7/fq xo0V8C5q6RENUmbYBY7JfIw4C9z7AdyBJltiUvezsyBeqmMusvNKSRvnSY15QHxr/FPt uGmeckSbsuuXHcy6dUkdqkVaV+mAqeD02Nf8R5lIVlfXUDavzkTlOho/eEQE68Gm/W2S nwVQwMzWvKBEjKnByQha0nvyvYkTJLRIaiBl0vWWLBkhHFM3vz3pROtLboelGEapccza QEysVT4vbtsiwdrO5ZJ1MomP+TNlvc/Cze1SZEiBFFU6mVVthTaxoadjUl04DEOIphNh TD6Q== X-Received: by 10.180.35.72 with SMTP id f8mr19434434wij.31.1426870348109; Fri, 20 Mar 2015 09:52:28 -0700 (PDT) Original-Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id e18sm7092711wjz.27.2015.03.20.09.52.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 09:52:27 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: <83siczvcss.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100714 Archived-At: On 03/20/2015 06:44 PM, Eli Zaretskii wrote: > To see how much of the time is taken by json-encode-char, replace it > with something trivial, like 1+, and see what speedup you get. Yep. Replacing the second definition with (defun json-encode-big-string (str) (with-temp-buffer (insert str) (goto-char (point-min)) (while (re-search-forward "[\"\\/\b\f\b\r\t]\\|[^ -~]" nil t) (replace-match "z" t t)) (format "\"%s\"" (buffer-string)))) still makes it take ~100ms on the example string (as opposed to 2ms in the optimized Python implementation).