From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20154@debbugs.gnu.org
Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings
Date: Fri, 20 Mar 2015 17:20:25 +0200 [thread overview]
Message-ID: <550C3AB9.7020403@yandex.ru> (raw)
In-Reply-To: <831tkjww0y.fsf@gnu.org>
On 03/20/2015 05:03 PM, Eli Zaretskii wrote:
> Yes, I could. What's your point, though?
That if asking the question takes the same time as doing the profiling
yourself, the latter would be more efficient. I don't really mind, just
puzzled.
> json-encode-char and mapconcat take most of the time, so it seems.
So it does. But here's an alternative implementation I tried:
(defun json-encode-big-string (str)
(with-temp-buffer
(insert str)
(goto-char (point-min))
(while (re-search-forward "[\"\\/\b\f\b\r\t]\\|[^ -~]" nil t)
(replace-match (json-encode-char (char-after (match-beginning 0)))
t t))
(format "\"%s\"" (buffer-string))))
It takes 0.15s here, which is still too long. Here's its profile.
CPU:
- command-execute 1245 95%
- call-interactively 1245 95%
- funcall-interactively 1184 90%
- eval-last-sexp 1140 87%
- elisp--eval-last-sexp 1140 87%
- eval 1140 87%
- length 1140 87%
- json-encode-big-string 1140 87%
- let 1140 87%
- save-current-buffer 1140 87%
- unwind-protect 1136 87%
- progn 1136 87%
- while 980 75%
- replace-match 332 25%
- json-encode-char 212 16%
char-after 4 0%
format 4 0%
+ execute-extended-command 37 2%
+ previous-line 7 0%
+ byte-code 61 4%
+ ... 57 4%
Memory:
- command-execute 76,018,070 100%
- call-interactively 76,018,070 100%
- funcall-interactively 76,005,728 99%
- eval-last-sexp 69,257,352 91%
- elisp--eval-last-sexp 69,257,352 91%
- eval 69,242,772 91%
- length 69,242,772 91%
- json-encode-big-string 69,242,772 91%
- let 69,242,772 91%
- save-current-buffer 69,234,412 91%
- unwind-protect 69,040,810 90%
- progn 69,033,546 90%
- while 55,201,778 72%
- replace-match 17,829,052 23%
json-encode-char 10,471,476 13%
format 2,640,256 3%
generate-new-buffer 8,360 0%
elisp--eval-last-sexp-print-value 12,532 0%
+ elisp--preceding-sexp 2,048 0%
- execute-extended-command 6,748,360 8%
- command-execute 6,685,480 8%
- call-interactively 6,685,480 8%
- funcall-interactively 6,685,464 8%
+ profiler-report 6,681,851 8%
+ profiler-start 3,613 0%
+ sit-for 3,320 0%
+ previous-line 16 0%
+ byte-code 12,342 0%
... 0 0%
next prev parent reply other threads:[~2015-03-20 15:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:26 bug#20154: 25.0.50; json-encode-string is too slow for large strings Dmitry Gutov
2015-03-20 14:34 ` Eli Zaretskii
2015-03-20 14:43 ` Dmitry Gutov
2015-03-20 15:03 ` Eli Zaretskii
2015-03-20 15:20 ` Dmitry Gutov [this message]
2015-03-20 16:02 ` Eli Zaretskii
2015-03-20 16:21 ` Dmitry Gutov
2015-03-20 16:44 ` Eli Zaretskii
2015-03-20 16:52 ` Dmitry Gutov
2015-03-20 17:44 ` Eli Zaretskii
2015-03-20 18:42 ` Dmitry Gutov
2015-03-20 21:14 ` Eli Zaretskii
2015-03-20 22:02 ` Dmitry Gutov
2015-03-21 7:58 ` Eli Zaretskii
2015-03-21 8:12 ` Eli Zaretskii
2015-03-21 20:00 ` Dmitry Gutov
2015-03-21 20:25 ` Eli Zaretskii
2015-03-21 21:26 ` Dmitry Gutov
2015-03-22 17:31 ` Eli Zaretskii
2015-03-22 18:13 ` Dmitry Gutov
2015-03-22 18:26 ` Dmitry Gutov
2015-03-22 18:32 ` Eli Zaretskii
2015-03-22 19:03 ` Dmitry Gutov
2015-03-21 21:05 ` Drew Adams
2015-03-21 21:32 ` Dmitry Gutov
2015-04-20 22:20 ` Ted Zlatanov
2015-04-20 22:41 ` Dmitry Gutov
2015-04-20 23:11 ` Ted Zlatanov
2015-03-20 22:26 ` Dmitry Gutov
2015-03-21 8:07 ` Eli Zaretskii
2015-03-21 21:09 ` Dmitry Gutov
2015-03-21 22:20 ` Ivan Shmakov
2015-03-21 23:36 ` Dmitry Gutov
2015-03-22 14:52 ` Dmitry Gutov
2015-03-22 16:15 ` Ivan Shmakov
2015-03-22 16:47 ` Dmitry Gutov
2015-03-22 17:43 ` Eli Zaretskii
2015-03-22 19:15 ` Ivan Shmakov
2015-03-22 16:51 ` Eli Zaretskii
2015-03-22 18:22 ` Glenn Morris
2015-03-22 16:50 ` Eli Zaretskii
2015-03-22 17:10 ` Dmitry Gutov
2015-03-22 22:57 ` Dmitry Gutov
2015-03-23 15:37 ` Eli Zaretskii
2015-04-07 13:31 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C3AB9.7020403@yandex.ru \
--to=dgutov@yandex.ru \
--cc=20154@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).