From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#20136: 25.0.50; [PATCH] Fix broken libpthread detection Date: Thu, 19 Mar 2015 18:35:39 -0700 Organization: UCLA Computer Science Department Message-ID: <550B796B.4000802@cs.ucla.edu> References: <85wq2e8epr.fsf@iznogoud.viz> <550B419C.50108@cs.ucla.edu> <85twxgtryk.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010909060502060604040604" X-Trace: ger.gmane.org 1426815390 22785 80.91.229.3 (20 Mar 2015 01:36:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 01:36:30 +0000 (UTC) To: Wolfgang Jenkner , 20136@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 02:36:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYlrH-0004Bc-Id for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 02:36:19 +0100 Original-Received: from localhost ([::1]:41996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYlrG-0005Ms-Uy for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Mar 2015 21:36:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYlr3-000530-K6 for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 21:36:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYlr0-00083z-Eg for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 21:36:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYlr0-00083t-BW for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 21:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYlqz-00030N-TQ for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 21:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 01:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20136-submit@debbugs.gnu.org id=B20136.142681535411535 (code B ref 20136); Fri, 20 Mar 2015 01:36:01 +0000 Original-Received: (at 20136) by debbugs.gnu.org; 20 Mar 2015 01:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:58667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYlqr-0002zz-Lg for submit@debbugs.gnu.org; Thu, 19 Mar 2015 21:35:53 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55967) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYlqn-0002zj-Es for 20136@debbugs.gnu.org; Thu, 19 Mar 2015 21:35:50 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 729C6A6000A; Thu, 19 Mar 2015 18:35:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l+X0XJA5BRp0; Thu, 19 Mar 2015 18:35:40 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 02F51A60006; Thu, 19 Mar 2015 18:35:40 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 In-Reply-To: <85twxgtryk.fsf@iznogoud.viz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100676 Archived-At: This is a multi-part message in MIME format. --------------010909060502060604040604 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Wolfgang Jenkner wrote: > -D_THREAD_SAFE or other flags are not needed on FreeBSD (since 7, > at least) OK, thanks, FreeBSD 6 was end-of-lifed some time ago and I assume Darwin is similar so I installed the attached simplification. --------------010909060502060604040604 Content-Type: text/x-patch; name="0001-configure.ac-_THREAD_SAFE-Simplify-Bug-20136.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-configure.ac-_THREAD_SAFE-Simplify-Bug-20136.patch" >From 84c6c65cb46bb9190fdd098e06e2109cdc7507d9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 19 Mar 2015 18:33:59 -0700 Subject: [PATCH] * configure.ac (_THREAD_SAFE): Simplify (Bug#20136). --- ChangeLog | 2 +- configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index d268ba0..a79863a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,7 +3,7 @@ Better port of pthread usage to FreeBSD * configure.ac (ac_func_list): Omit pthread_sigmask, since we check for that ourselves rather than relying on gnulib. - (HAVE_PTHREAD, LIB_PTHREAD, _THREAD_SAFE): Port better to FreeBSD, + (HAVE_PTHREAD, LIB_PTHREAD): Port better to FreeBSD, by also checking for pthread_create, pthread_self, pthread_sigmask. Tighten the test for pthread_atfork while we're at it. Fixes: bug#20136 diff --git a/configure.ac b/configure.ac index 520816b1..40c8d2b 100644 --- a/configure.ac +++ b/configure.ac @@ -2234,7 +2234,7 @@ if test "$ac_cv_header_pthread_h" && test "$opsys" != "mingw32"; then hpux* | sol*) AC_DEFINE([_REENTRANT], 1, [Define to 1 if your system requires this in multithreaded code.]);; - aix4-2 | darwin | freebsd) + aix4-2) AC_DEFINE([_THREAD_SAFE], 1, [Define to 1 if your system requires this in multithreaded code.]);; esac -- 2.1.0 --------------010909060502060604040604--