* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
@ 2015-03-16 15:59 Ken Brown
2015-03-16 18:49 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2015-03-16 15:59 UTC (permalink / raw)
To: 20118
The outward symptom is almost identical to that of Bug#20117, but I
don't know if the present bug is related, because it's been happening
for as long as I can remember; I just never got around to reporting it.
Test tramp-test29-vc-registered aborted with non-local exit
ABORTED 30/41 tramp-test29-vc-registered
Aborted: Ran 41 tests, 28 results as expected, 1 skipped (2015-03-16
11:34:07-0400)
1 skipped results:
SKIPPED tramp-test19-directory-files-and-attributes
Error running tests
backtrace()
(progn (message "Error running tests") (backtrace))
(unwind-protect (progn (message "Error running tests") (backtrace))
(kill-emacs 2))
(unwind-protect (let ((stats (ert-run-tests-batch selector)))
(kill-emacs (if (= 0 (ert-stats-completed-unexpected stats)) 0 1)))
(unwind-protect (progn (message "Error running tests") (backtrace))
(kill-emacs 2)))
ert-run-tests-batch-and-exit()
command-line-1(("-L" ":." "-l" "ert" "-l" "tramp-tests.elc" "-f"
"ert-run-tests-batch-and-exit"))
command-line()
normal-top-level()
Makefile:85: recipe for target 'tramp-tests.log' failed
In GNU Emacs 25.0.50.5 (x86_64-unknown-cygwin, GTK+ Version 3.14.9)
of 2015-03-16 on moufang
Repository revision: 5d9b1e100aa4ddb79471f7ec2347fdb65d6a9a70
Windowing system distributor `The Cygwin/X Project', version 11.0.11701000
Configured using:
`configure --without-all --cache-file=/tmp/config.cache'
Configured features:
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
lisp/emacs-lisp/eieio.el: `eieio-object-name-string' is an obsolete
generic function (as of 25.1); use `eieio-named' instead.
lisp/gnus/auth-source.el: Obsolete name arg "Empty" to constructor
auth-source-backend
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message dired desktop frameset edmacro
kmacro format-spec rfc822 mml easymenu url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
url-parse auth-source eieio byte-opt bytecomp byte-compile cconv
eieio-core cl-generic cl-extra seq url-vars mm-view mml-smime smime
password-cache dig mailcap mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev easy-mmode nnheader gnus-util rmail dframe
gmm-utils mailheader sendmail derived rfc2047 rfc2045 ietf-drums mm-util
help-fns mail-prsvr cl cl-macs inline cl-loaddefs cl-lib gv pcase
mail-utils time-date tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dynamic-setting move-toolbar gtk x-toolkit x multi-tty emacs)
Memory information:
((conses 16 302799 13893)
(symbols 48 22757 0)
(miscs 40 41 155)
(strings 32 21421 5642)
(string-bytes 1 794394)
(vectors 16 7973)
(vector-slots 8 378230 25870)
(floats 8 118 129)
(intervals 56 186 0)
(buffers 976 12))
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
2015-03-16 15:59 bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin Ken Brown
@ 2015-03-16 18:49 ` Michael Albinus
2015-03-17 2:22 ` Ken Brown
0 siblings, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2015-03-16 18:49 UTC (permalink / raw)
To: Ken Brown; +Cc: 20118
Ken Brown <kbrown@cornell.edu> writes:
> The outward symptom is almost identical to that of Bug#20117, but I
> don't know if the present bug is related, because it's been happening
> for as long as I can remember; I just never got around to reporting it.
>
> Test tramp-test29-vc-registered aborted with non-local exit
> ABORTED 30/41 tramp-test29-vc-registered
Please instrument it similar to the recipe in bug#20117.
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
2015-03-16 18:49 ` Michael Albinus
@ 2015-03-17 2:22 ` Ken Brown
2015-03-17 10:36 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2015-03-17 2:22 UTC (permalink / raw)
To: Michael Albinus; +Cc: 20118
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On 3/16/2015 2:49 PM, Michael Albinus wrote:
> Ken Brown <kbrown@cornell.edu> writes:
>
>> The outward symptom is almost identical to that of Bug#20117, but I
>> don't know if the present bug is related, because it's been happening
>> for as long as I can remember; I just never got around to reporting it.
>>
>> Test tramp-test29-vc-registered aborted with non-local exit
>> ABORTED 30/41 tramp-test29-vc-registered
>
> Please instrument it similar to the recipe in bug#20117.
Output attached.
I did this test on a checkout of revision 5d9b1e100, which preceded the
problem reported in bug#20117.
Ken
[-- Attachment #2: test29.log.gz --]
[-- Type: application/gzip, Size: 73738 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
2015-03-17 2:22 ` Ken Brown
@ 2015-03-17 10:36 ` Michael Albinus
2015-03-17 13:05 ` Ken Brown
0 siblings, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2015-03-17 10:36 UTC (permalink / raw)
To: Ken Brown; +Cc: 20118
Ken Brown <kbrown@cornell.edu> writes:
>>> The outward symptom is almost identical to that of Bug#20117, but I
>>> don't know if the present bug is related, because it's been happening
>>> for as long as I can remember; I just never got around to reporting it.
>>>
>>> Test tramp-test29-vc-registered aborted with non-local exit
>>> ABORTED 30/41 tramp-test29-vc-registered
>>
>> Please instrument it similar to the recipe in bug#20117.
>
> Output attached.
Well, this bug is different from Bug#20117. A shell function Tramp sends
to the remote host contains some lines with leading TABs. Your bash tries
to expand them.
The following patch shall fix this.
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/tramp/lisp/tramp-sh.el.~master~ 2015-03-17 11:25:13.857882111 +0100
--- /home/albinus/src/tramp/lisp/tramp-sh.el 2015-03-17 11:24:45.233315481 +0100
***************
*** 3725,3730 ****
--- 3725,3734 ----
(tramp-get-connection-process vec) "scripts" nil)))
(unless (member name scripts)
(with-tramp-progress-reporter vec 5 (format "Sending script `%s'" name)
+ ;; In bash, leading TABs like in `tramp-vc-registered-read-file-names'
+ ;; could result in unwanted command expansion. Avoid this.
+ (setq script (tramp-compat-replace-regexp-in-string
+ (make-string 1 ?\t) (make-string 8 ? ) script))
;; The script could contain a call of Perl. This is masked with `%s'.
(when (and (string-match "%s" script)
(not (tramp-get-remote-perl vec)))
--8<---------------cut here---------------end--------------->8---
> Ken
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
2015-03-17 10:36 ` Michael Albinus
@ 2015-03-17 13:05 ` Ken Brown
2015-03-17 19:09 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2015-03-17 13:05 UTC (permalink / raw)
To: Michael Albinus; +Cc: 20118
On 3/17/2015 6:36 AM, Michael Albinus wrote:
> Well, this bug is different from Bug#20117. A shell function Tramp sends
> to the remote host contains some lines with leading TABs. Your bash tries
> to expand them.
>
> The following patch shall fix this.
[...]
Confirmed. Now all Tramp tests give the expected results on rev 5d9b1e100.
Thanks!
Ken
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
2015-03-17 13:05 ` Ken Brown
@ 2015-03-17 19:09 ` Michael Albinus
0 siblings, 0 replies; 6+ messages in thread
From: Michael Albinus @ 2015-03-17 19:09 UTC (permalink / raw)
To: Ken Brown; +Cc: 20118
Ken Brown <kbrown@cornell.edu> writes:
> Confirmed. Now all Tramp tests give the expected results on rev 5d9b1e100.
Thanks for checking. I've committed the patch to the master branch,
closing the bug.
> Ken
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-17 19:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 15:59 bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin Ken Brown
2015-03-16 18:49 ` Michael Albinus
2015-03-17 2:22 ` Ken Brown
2015-03-17 10:36 ` Michael Albinus
2015-03-17 13:05 ` Ken Brown
2015-03-17 19:09 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).