From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 20 Dec 2018 02:11:20 +0200 Message-ID: <54f63175-1def-7227-e10b-e806002f0ed1@yandex.ru> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <87woo5i3x3.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545264621 15781 195.159.176.226 (20 Dec 2018 00:10:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2018 00:10:21 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 20 01:10:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZluq-000407-Rs for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 01:10:17 +0100 Original-Received: from localhost ([::1]:34717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZlwx-000139-GB for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 19:12:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZlwk-00012M-Eb for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 19:12:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZlwb-00086A-1n for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 19:12:13 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZlwY-0007vj-P5 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 19:12:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZlwY-0000BF-5l for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 19:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2018 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.1545264691647 (code B ref 33567); Thu, 20 Dec 2018 00:12:02 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 20 Dec 2018 00:11:31 +0000 Original-Received: from localhost ([127.0.0.1]:55301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZlw3-0000AN-2e for submit@debbugs.gnu.org; Wed, 19 Dec 2018 19:11:31 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:53112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZlw1-0000A8-N7 for 33567@debbugs.gnu.org; Wed, 19 Dec 2018 19:11:30 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id m1so227312wml.2 for <33567@debbugs.gnu.org>; Wed, 19 Dec 2018 16:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ncfxa66eyKlqRisDVlQPG0eaPO3RRpqmR9uBYrdnV4Y=; b=TBEim1EaXq8SmcyDNSRjePXuiVB2FQx8Dx1IxCymzNKcudVezx9VZzuWxpb3IVNn12 vxiY/68/fN91owB1S0PIPyxUJ2QtmuRFDgDMdCxtr3GrFAQdFIjTSUyjDX1IvmtBY61p Qk0KANjv3AQIA7bEmYOiD3CS7fZ5VgKkSSa/sd30XLLUAKvuFkP0Dd/onxKTw28rrN9/ kIK3lD0TRIsXcQnUKq2r5Zb4D3qnxQlcKHs6EtvA25Pr1y0tthLoBz4VfpE9a+ZjaQfD u8lPe2zn5rj6wE1J0ewWkJD95vSDs0oB3xc8j0XEBXFbzKu12agxTAEcIcmY9IUr5X1D M/2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ncfxa66eyKlqRisDVlQPG0eaPO3RRpqmR9uBYrdnV4Y=; b=cbLRUHs39fMjqdMlB0h04QUNgRgB6swr498Ozm3KoRkZuhT2wLeOyiHPN9N7ZhN54c xP2jESFmVcTebobpXToSTfbL8XGSFsrwq51+6rhf1atIOKs1lyPQcgXHrzFOo0HN9Edy LtLMLz94Ol6qZI1Z4f/TAw5RqkUrlSxKBs8xZud8EHQRhvnHu6S1uq0wEl4a68xHAZaa L/eQIMT9xMHLFpuEN6g9R5f2aSu/OXqXKzVGml+drkvhmTQWYo7JAJqAUXXhBUj6AQrP i0zQyu1p/IGsPTut4ziIJeNspwSB/6KvO5aRR5h+rmvc601Q7JLQeLXHCS91slV1hWeV ZFkw== X-Gm-Message-State: AA+aEWY5GTYSw1D2g6uBWUaY+LW3cXqXLJyZWURDvvs6cX01iBwcwnpH bqCRG3LIQpcoowP88Efk13QjxTaw X-Google-Smtp-Source: AFSGD/VTKWwdlgzKAWD5c48Dfmk0+LQLPSUO98RV4aF46rumvHaRxHnnPANq56If+QQMQNJo2hVVIg== X-Received: by 2002:a1c:11c1:: with SMTP id 184mr8539688wmr.59.1545264683643; Wed, 19 Dec 2018 16:11:23 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id m15sm6432281wrr.95.2018.12.19.16.11.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Dec 2018 16:11:22 -0800 (PST) In-Reply-To: <87woo5i3x3.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153629 Archived-At: On 19.12.2018 23:51, Juri Linkov wrote: > A worse situation with Magit - I was asked to update Magit > to use this feature, but I don't know where to start: > Magit uses green/red colors both for background and foreground. Are there cases where it uses only red/green foreground to show a hunk? I would honestly just skip those cases, if Magit insists on doing things in several different ways. Not sure why you need to port the new feature yourself, though.