From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? Date: Fri, 04 May 2018 09:34:47 +1200 Message-ID: <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> References: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> <87k1sksquk.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1525383194 5265 195.159.176.226 (3 May 2018 21:33:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 21:33:14 +0000 (UTC) User-Agent: Orcon Webmail Cc: 31357@debbugs.gnu.org, bug-gnu-emacs To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 23:33:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fELqf-0001BZ-Be for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 23:33:09 +0200 Original-Received: from localhost ([::1]:59196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fELsf-00049Z-DE for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 17:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fELsV-00047f-RA for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 17:35:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fELsU-0008RP-Lw for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 17:35:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fELsU-0008Qy-IY for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 17:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fELsU-0005cj-7w for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 17:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31357-submit@debbugs.gnu.org id=B31357.152538329221600 (code B ref 31357); Thu, 03 May 2018 21:35:02 +0000 Original-Received: (at 31357) by debbugs.gnu.org; 3 May 2018 21:34:52 +0000 Original-Received: from localhost ([127.0.0.1]:48665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fELsK-0005cJ-IB for submit@debbugs.gnu.org; Thu, 03 May 2018 17:34:52 -0400 Original-Received: from smtp-4.orcon.net.nz ([60.234.4.59]:38371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fELsI-0005cA-Dp for 31357@debbugs.gnu.org; Thu, 03 May 2018 17:34:51 -0400 Original-Received: from [10.253.37.70] (port=39803 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fELsF-0005a1-92; Fri, 04 May 2018 09:34:47 +1200 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 04 May 2018 09:34:47 +1200 In-Reply-To: <87k1sksquk.fsf@gmx.de> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145998 Archived-At: On 2018-05-04 03:26, Michael Albinus wrote: > Phil Sainty writes: >> This should surely be covered in NEWS under the "Incompatible Lisp >> Changes in Emacs 26.1" section? > > `tramp-make-tramp-file-name' has never been documented as public > function, it is intended for internal use. Granted, this should have > been signalled better. Given the function naming, a NEWS entry seems warranted to me. I do think that there *should* be a public interface for manipulating tramp file names. If these were never intended as such then perhaps such functionality could be introduced... > That's the way to go. You could use (funcall > 'tramp-make-tramp-file-name ...) > in order to make the byte compiler quiet. Perfect. > However, I wouldn't check for emacs-version. Tramp exist as separate > package, and the recent Tramp 2.4 runs with all Emacs 24, 25, 26 and > 27. You might check for tramp-version. Thanks; I've gone with this: (apply #'tramp-make-tramp-file-name (if (version< tramp-version "2.3") (list method user host temp hop) (list method user domain host port temp hop))) The changes in 2.4 sound good too. > (setf (tramp-file-name-host vec) "whatever") Ah, I'd actually tried that in 25.2 but those are not generalized variables in that version. I see that it works in 26.1 though, so that's an excellent enhancement. cheers, -Phil