From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Tue, 14 Nov 2023 22:32:24 -0800 Message-ID: <54F9F1A6-5162-4115-93CE-633B2349AC76@gmail.com> References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill , 66988@debbugs.gnu.org, =?UTF-8?Q?Lo=C3=AFc_?= =?UTF-8?Q?Lema=C3=AEtre?= To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 16:59:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3IIJ-0006Em-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 16:59:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3IIC-0004Kx-EH; Wed, 15 Nov 2023 10:59:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3IIB-0004Km-GK for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:59:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IIB-0005qw-7Z for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IIA-0001BQ-9F for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.17000639304526 (code B ref 66988); Wed, 15 Nov 2023 15:59:02 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 15 Nov 2023 15:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:52971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IHy-0001Aw-6Z for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:58:50 -0500 Original-Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:57798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IHv-0001Ah-NJ for 66988@debbugs.gnu.org; Wed, 15 Nov 2023 10:58:49 -0500 Original-Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-28094a3b760so570574a91.3 for <66988@debbugs.gnu.org>; Wed, 15 Nov 2023 07:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700063922; x=1700668722; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xIZzjr2SBWaFD8s+O0cBG1CS9ZPWNI244ON+uSfpU2c=; b=nH8Piqc8xxDQp0UBzlhObqrS96x/+y/tqeboXgj4lkctk44GEQ9ZbCl8bp7xctI3qc F/sjJjoZc+SzdVq+gq8IRAXRBmHIGLM6xsDy4HgjSmN0zuQBz/tP36NyxxBBKZ6XMBJW bPspep8kOLRCzdwkkFj+PLxd1hfjwrTBeKkkXLE8rZdSujPGjbyWIolgJc8E4Bn6WWzt 8IMJbLBy6i8rst1fi+mfIVjvB8nWEY7iW1iGsGgpYnyAeZILNO2zLpu0UqmIRrRzTuMf gTcvjeoM9NMefOcGhA4HoWXvx6PPvamtTHbHCbe78Y/YLx4/BA9WEwgq/pkry6ewPhqg RqlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700063922; x=1700668722; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIZzjr2SBWaFD8s+O0cBG1CS9ZPWNI244ON+uSfpU2c=; b=ZRrVO9VPBe0GS7dJxSXhyh4xq1gus5zT5kuKXEeoXPmJihFnDv4/kuvee3TxK4xfbO 728nFgtIpFJ0VPG2kHZtZJe9feFN4ABDaZ/a6zyResfHyOlNOHbRAYOsIL0h/bvO985e swHY7SCIaRSIHsu/MAGZHfKzgBkg/x2verNJ7IFvbTi8d2Zff8jxYwfmLVKwd26Ako5N 3gB6yhj+JdH3rziJXXrPNoSn4QYBKD38r7SJaKQFIYUM8Zf8s41tVeUbCMjkRN25EX5q d6frRFsXK3voLyKPt7Yjq5TOiBoxN5V4mWZhUJfdsC8vxwkeraU9bUWn2qaxR8ZTFVfs s+WA== X-Gm-Message-State: AOJu0Yw16PKq4+0esiqy0ehZsuD1vDe92yVVSiSYmii5BMkz94vfb0H0 rrSnefV/ibizE1y3oS42L9y1pDomwY8= X-Google-Smtp-Source: AGHT+IEplFS9TzedmweDiuc9C0qQIi3jyD0Zw4qLSxM26YVTcOoY6xb0J1tizmrzmsK1djesXSZPMw== X-Received: by 2002:a17:903:244d:b0:1cc:2ef7:2abe with SMTP id l13-20020a170903244d00b001cc2ef72abemr5176670pls.48.1700029955665; Tue, 14 Nov 2023 22:32:35 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j9-20020a170903024900b001b8b1f6619asm6741401plh.75.2023.11.14.22.32.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2023 22:32:35 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274356 Archived-At: > On Nov 11, 2023, at 2:49 AM, Dmitry Gutov wrote: >=20 > On 11/11/2023 04:41, Yuan Fu wrote: >> I regret not doing this by default for treesit-indent-rules and = traverse functions. Now it=E2=80=99s hard to change without creating = confusion and breaking backward compatibility. I wonder if there are = good way to smoothly transition to match full names by default=E2=80=A6 >> Treesit-thing-settings can be changed to match full names, but only = if we can change treesit-indent-rules and friends too. Otherwise it = would be too confusing. >=20 > It's my understanding that the current implementation, when it doesn't = use a full match, is a potential bug in every single instance. That=E2=80=99s a good point. > Perhaps you have an example of when partial match is intended and = beneficial? If so, we can just go through all other regexps and wrap = them in \` and \'. And should. I don=E2=80=99t, except for a very few cases where I saved typing a few = characters. You have a good point. I think most people instinctively write the full = match in their code anyway, so changing to the full match should be = fine. We can start from master and see if the world ends or not.=20 Yuan=