unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: <12232@debbugs.gnu.org>
Subject: bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands
Date: Mon, 3 Sep 2012 08:33:12 -0700	[thread overview]
Message-ID: <54F3F95EA9924540A41367629A87A389@us.oracle.com> (raw)
In-Reply-To: <14F60E44174644FBA0F21D20D1477DD4@us.oracle.com>

ping.

Stefan, could you please take a look at this?

I diff'd the change you made on 2012-05-05, but the code and the change is not
easy (for me) to fathom.

This comment in the version of repeat.el before your change might be pertinent,
as it refers to a symptom (nesting exceeding `max-lisp-eval-depth') similar to
what I am seeing now:

      ;; A simple recursion here gets into trouble with max-lisp-eval-depth
      ;; on long sequences of repetitions of a command like `forward-word'
      ;; (only 32 repetitions are possible given the default value of 200 for
      ;; max-lisp-eval-depth), but if I now locally disable the repeat char I
      ;; can iterate indefinitely here around a single level of recursion.

Thx - Drew

> ping.
> 
> > I believe this regression was introduced by the following commit:
> > Stefan Monnier2012-05-05 02:50:20Revision ID: 
> > monnier@iro.umontreal.ca-2012=
> > 0505025020-ihjvoqehkrxkfxw8
> >  
> > Use set-temporary-overlay-map.
> > * lisp/repeat.el: Use lexical-binding.
> > (repeat-last-self-insert, repeat-num-input-keys-at-self-insert)
> > (repeat-undo-count): Remove.
> > (repeat):
...
> >
Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-d=
epth'")
  repeat(nil)
  call-interactively(repeat)
  #[0 "..." [ignore repeat-message-function this-command repeat call-intera=
ctively] 2 "\n\n(fn)" nil]()
  call-interactively(#[0 "..." [ignore repeat-message-function this-command=
 repeat call-interactively] 2 "\n\n(fn)" nil])
  repeat(nil)
  call-interactively(repeat)
  #[0 "..." [ignore repeat-message-function this-command repeat call-intera=
ctively] 2 "\n\n(fn)" nil]()
  call-interactively(#[0 "..." [ignore
  repeat-message-function this-command repeat call-interactively] 2
  "\n\n(fn)" nil])
...
  repeat(nil)
  call-interactively(repeat)
...






  reply	other threads:[~2012-09-03 15:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-19  2:55 bug#12232: 24.1.50; regression: repeat.el commit 2012-05-05 breaks repeating commands Drew Adams
2012-08-24 14:57 ` Drew Adams
2012-09-03 15:33   ` Drew Adams [this message]
2012-09-04  3:53     ` Drew Adams
2012-09-16 23:31       ` Drew Adams
2012-09-24  0:48         ` Drew Adams
2012-10-19  1:54           ` Drew Adams
2012-10-19 14:16             ` Stefan Monnier
2012-10-19 14:32               ` Drew Adams
2012-10-23 16:58       ` Stefan Monnier
2012-10-23 17:08         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F3F95EA9924540A41367629A87A389@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=12232@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).