unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Jorgen Schaefer <contact@jorgenschaefer.de>, 19962@debbugs.gnu.org
Subject: bug#19962: 25.0.50; window-configuration-change-hook not running on trunk
Date: Fri, 27 Feb 2015 20:57:28 +0100	[thread overview]
Message-ID: <54F0CC28.9030909@gmx.at> (raw)
In-Reply-To: <87fv9r6vuz.fsf@loki.jorgenschaefer.de>

 > With recent Emacs versions from trunk, it seems
 > `window-configuration-change-hook' is not run anymore.
 >
 > Reproduction:
 >
 > (setq window-configuration-change-hook
 >        '((lambda ()
 >            (message "Change!"))))
 >
 > C-x 2 => does not show "Change!"
 >
 > In Emacs 24.4, this still happened.
 >
 > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu)
 >   of 2015-02-21 on loki.jorgenschaefer.de
 > Repository revision: 9074a684990600abd9dfad0477c7cd1d2f339ed3
 > System Description:	Debian GNU/Linux 7.8 (wheezy)
 >
 > Same behavior in b2a590d4e3dc692a97c1b53e015b945d84b4b4c7 from
 > 2015-02-27.
 >
 >
 > Configured using:
 >   `configure --without-x'

Bad.  Does the following patch fix it?

diff --git a/src/window.c b/src/window.c
index d59616d..efbe70f 100644
--- a/src/window.c
+++ b/src/window.c
@@ -3328,7 +3328,9 @@ run_window_configuration_change_hook (struct frame *f)
    XSETFRAME (frame, f);

    if (NILP (Vrun_hooks)
+#ifdef HAVE_WINDOW_SYSTEM
        || !(f->can_x_set_window_size)
+#endif
        || !(f->after_make_frame))
      return;


martin





  reply	other threads:[~2015-02-27 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 18:40 bug#19962: 25.0.50; window-configuration-change-hook not running on trunk Jorgen Schaefer
2015-02-27 19:57 ` martin rudalics [this message]
2015-02-28 18:50 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F0CC28.9030909@gmx.at \
    --to=rudalics@gmx.at \
    --cc=19962@debbugs.gnu.org \
    --cc=contact@jorgenschaefer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).