unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: 17945@debbugs.gnu.org
Subject: bug#17945: 24.4.50; vc-git-annotate-command is too slow
Date: Wed, 25 Feb 2015 22:37:09 +0200	[thread overview]
Message-ID: <54EE3275.6050402@yandex.ru> (raw)
In-Reply-To: <87bnkh9880.fsf@wanadoo.es>

On 02/25/2015 08:06 PM, Óscar Fuentes wrote:

> vc-switches does check `vc-annotate-switches' (as it checks
> vc-OP-switches for any other OP and BACKEND), so we are hiding
> information from the user.

But there's no such user option. And if a variable with that name is 
created, well, the user stepped on something nobody asked them too.

> The whole problem consists on a generic approach (vc-OP-switches) that
> doesn't play nice for some (all?) OPs. So we either get rid of
> `vc-OP-switches' entirely or warn the user about its pitfalls.

I think in this case we can just as well avoid using `vc-switches' and 
reference `vc-git-annotate-switches' directly.

> (Is there an OP where `vc-OP-switches' works well across more than two
> supported backends?)

vc-diff-switches works pretty well.

The rest of -switches variables, though, look similarly suspicious to 
me. That's vc-checkin-switches, vc-checkout-switches and 
vc-register-switches.





  reply	other threads:[~2015-02-25 20:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05 12:28 bug#17945: 24.4.50; vc-git-annotate-command is too slow William Xu
2014-07-05 13:34 ` Dmitry
2014-07-05 15:16   ` William Xu
2014-07-05 16:15   ` Stefan Monnier
2015-02-24  7:39     ` Glenn Morris
2015-02-24 15:31       ` Óscar Fuentes
2015-02-24 16:12         ` Eli Zaretskii
2015-02-24 16:36           ` Dmitry Gutov
2015-02-24 17:57         ` Glenn Morris
2015-02-24 20:55           ` Dmitry Gutov
2015-02-24 22:25             ` Óscar Fuentes
2015-02-25 17:46             ` Óscar Fuentes
2015-02-25 17:58               ` Dmitry Gutov
2015-02-25 18:06                 ` Óscar Fuentes
2015-02-25 20:37                   ` Dmitry Gutov [this message]
2015-02-26 14:56           ` Óscar Fuentes
2015-02-24 16:47       ` Dmitry Gutov
2015-02-24 17:56         ` Glenn Morris
2015-02-24 18:04           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EE3275.6050402@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=17945@debbugs.gnu.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).