From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 11:15:18 -0500 Message-ID: <54E75D96.70601@cornell.edu> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1424448987 20041 80.91.229.3 (20 Feb 2015 16:16:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 16:16:27 +0000 (UTC) Cc: 19909@debbugs.gnu.org, rpluim@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 17:16:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOqFQ-0000cG-6y for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 17:16:12 +0100 Original-Received: from localhost ([::1]:32933 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqFP-0000w3-K4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 11:16:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqFM-0000j0-1F for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:16:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqFH-0001vg-0q for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:16:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqFG-0001vc-Tu for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOqFG-0006ji-FF for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Robert Pluim Original-Received: via spool by submit@debbugs.gnu.org id=B.142444892423126 (code B ref -1); Fri, 20 Feb 2015 16:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 16:15:24 +0000 Original-Received: from localhost ([127.0.0.1]:49636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqEd-00060L-Lt for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43746) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqEb-0005xK-72 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqEU-0001ns-3K for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:20 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqEU-0001nj-0w for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqET-0004sP-1U for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:15:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqEM-0001gD-Pm for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:15:12 -0500 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:44716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqEM-0001W1-Mk; Fri, 20 Feb 2015 11:15:06 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1KGExiP001421; Fri, 20 Feb 2015 11:14:59 -0500 Original-Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1KGEw3G013429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 20 Feb 2015 11:14:59 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: <838ufslitm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99647 Archived-At: On 2/20/2015 10:10 AM, Eli Zaretskii wrote: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 15:16:49 +0100 >> >>> According to the comment in w32notify.c, w32.h is included only for >>> w32_strerror. Could you try commenting out the w32.h inclusion, and >>> instead copy the w32_strerror prototype into w32notify.c? Does Emacs >>> compile then as part of the Cygwin-w32 build, and do file >>> notifications work? (I don't have Cygwin installed to try that, >>> sorry.) >>> >> >> No, that doesn't compile. w32notify.c needs (at least) >> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >> w32_valid_pointer_p() from w32.c. > > Right. But those problems are quite simple to solve. > > Ken, would you like to try to solve them? I could suggest a patch, > but it would be 100% untested. I'm busy with other things at the moment and can't get to it right away. If it's easy for you to suggest a patch, why don't you go ahead, and Robert can test it. Or you can wait a couple weeks until I can look at it. BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm not sure there's any need to put a lot of effort into this. Ken