From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19909@debbugs.gnu.org, rpluim@gmail.com
Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Fri, 20 Feb 2015 11:15:18 -0500 [thread overview]
Message-ID: <54E75D96.70601@cornell.edu> (raw)
In-Reply-To: <838ufslitm.fsf@gnu.org>
On 2/20/2015 10:10 AM, Eli Zaretskii wrote:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 20 Feb 2015 15:16:49 +0100
>>
>>> According to the comment in w32notify.c, w32.h is included only for
>>> w32_strerror. Could you try commenting out the w32.h inclusion, and
>>> instead copy the w32_strerror prototype into w32notify.c? Does Emacs
>>> compile then as part of the Cygwin-w32 build, and do file
>>> notifications work? (I don't have Cygwin installed to try that,
>>> sorry.)
>>>
>>
>> No, that doesn't compile. w32notify.c needs (at least)
>> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and
>> w32_valid_pointer_p() from w32.c.
>
> Right. But those problems are quite simple to solve.
>
> Ken, would you like to try to solve them? I could suggest a patch,
> but it would be 100% untested.
I'm busy with other things at the moment and can't get to it right away.
If it's easy for you to suggest a patch, why don't you go ahead, and
Robert can test it. Or you can wait a couple weeks until I can look at it.
BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm
not sure there's any need to put a lot of effort into this.
Ken
next prev parent reply other threads:[~2015-02-20 16:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 9:47 bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Robert Pluim
2015-02-20 10:06 ` Eli Zaretskii
2015-02-20 10:19 ` Robert Pluim
2015-02-20 10:46 ` Eli Zaretskii
2015-02-20 14:16 ` Robert Pluim
2015-02-20 15:10 ` Eli Zaretskii
2015-02-20 15:46 ` Robert Pluim
2015-02-20 16:17 ` Eli Zaretskii
2015-02-20 16:44 ` Robert Pluim
2015-02-20 17:16 ` Eli Zaretskii
2015-02-20 16:15 ` Ken Brown [this message]
2015-02-20 17:06 ` Robert Pluim
2015-02-20 17:18 ` Eli Zaretskii
2015-02-27 22:25 ` Ken Brown
2015-02-28 7:59 ` Eli Zaretskii
2015-02-28 16:32 ` Ken Brown
2015-02-28 16:41 ` Eli Zaretskii
2015-02-28 16:53 ` Robert Pluim
2015-02-28 16:56 ` Robert Pluim
2015-02-28 17:57 ` Eli Zaretskii
2015-02-28 18:44 ` Ken Brown
2015-02-28 19:14 ` Eli Zaretskii
2015-02-28 20:14 ` Ken Brown
2015-03-02 9:35 ` Robert Pluim
2015-03-02 14:05 ` Ken Brown
2015-03-02 14:06 ` bug#19909: closed (Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin) GNU bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E75D96.70601@cornell.edu \
--to=kbrown@cornell.edu \
--cc=19909@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).