From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19732: 25.0.50; Wrong type argument: arrayp when running vc-dir on a CVS repo Date: Fri, 30 Jan 2015 20:34:40 +0200 Message-ID: <54CBCEC0.9070705@yandex.ru> References: <889oapgo1jl.fsf@broadcom.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1422642916 2812 80.91.229.3 (30 Jan 2015 18:35:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Jan 2015 18:35:16 +0000 (UTC) To: Rupert Swarbrick , 19732@debbugs.gnu.org, "Eric S. Raymond" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 30 19:35:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHGPR-000773-6x for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jan 2015 19:35:13 +0100 Original-Received: from localhost ([::1]:38184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHGPQ-0004z9-Ek for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jan 2015 13:35:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHGPM-0004xn-1O for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 13:35:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHGPG-0005gY-So for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 13:35:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHGPG-0005g1-Oy for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 13:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YHGPF-0001wN-W7 for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 13:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jan 2015 18:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19732-submit@debbugs.gnu.org id=B19732.14226428907438 (code B ref 19732); Fri, 30 Jan 2015 18:35:01 +0000 Original-Received: (at 19732) by debbugs.gnu.org; 30 Jan 2015 18:34:50 +0000 Original-Received: from localhost ([127.0.0.1]:58264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHGP3-0001vu-Rx for submit@debbugs.gnu.org; Fri, 30 Jan 2015 13:34:50 -0500 Original-Received: from mail-we0-f175.google.com ([74.125.82.175]:63581) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHGP1-0001vf-UC for 19732@debbugs.gnu.org; Fri, 30 Jan 2015 13:34:48 -0500 Original-Received: by mail-we0-f175.google.com with SMTP id p10so28749995wes.6 for <19732@debbugs.gnu.org>; Fri, 30 Jan 2015 10:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lxip0QtoUSFK6R3ptI4gb+Nefh3PUtZrSl976L/bTJA=; b=bdehkkRGNOhu77SqDGOlg5PN5hT+gZaJJ0GK+K+gB/SNF873CltNvu8y8rE1AAKxn9 2qt9lwih4nGO3cueFd8dSVNWFBCV1XnVyJO5dGdT4E+3/qWAw2TahhFLoi2cYl5A1WZL x7QAcDmpXW1ikWQwnA/TCr//+o6SGFJ8/ren0DG6pCp7Dv/OIcUkJnMKRyFSkBwmlfdh E5No+WChvD988Zrjzlyep9i2YXXCGPlrFvmU1Go5TxVX1xW/6qoBhgjjOvoaKf6fXU71 gf5GvSSCE4G3mHNBRusM8tV9UylMD9DquL5poTz2A47YWtuA8THe9ZSPyJK3WnFftpg7 2w5Q== X-Received: by 10.180.93.132 with SMTP id cu4mr7268844wib.49.1422642882291; Fri, 30 Jan 2015 10:34:42 -0800 (PST) Original-Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id oo8sm4696761wjc.1.2015.01.30.10.34.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 10:34:41 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 In-Reply-To: <889oapgo1jl.fsf@broadcom.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98912 Archived-At: Rupert, please try this patch instead: <-- diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el index d803c16..707090a 100644 --- a/lisp/vc/vc-cvs.el +++ b/lisp/vc/vc-cvs.el @@ -1076,7 +1076,7 @@ Query all files in DIR if files is nil." (if (and (not files) local (not (eq local 'only-file))) (vc-cvs-dir-status-heuristic dir update-function) (if (not files) (setq files (vc-expand-dirs (list dir) 'CVS))) - (vc-cvs-command (current-buffer) 'async dir "-f" "status" files) + (vc-cvs-command (current-buffer) 'async files "-f" "status") ;; Alternative implementation: use the "update" command instead of ;; the "status" command. ;; (vc-cvs-command (current-buffer) 'async <-- On 01/30/2015 03:12 PM, Rupert Swarbrick wrote: > (apply #'vc-cvs-command > (append (list (current-buffer) 'async dir "-f" "status") > files)) > > (which would be neater with a Common Lisp style apply: maybe there's a > more standard emacs lisp idiom for this?) AFAICS, they work the same. So you wouldn't need the `append'. > I'm not sending a patch with this bug report because I still haven't > gotten around to filing copyright assignment papers with the FSF, > sorry. So someone else gets to do the typing... Have you exceeded the allowed limit? 10-15 lines of code without assignment are fine.