From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6130@debbugs.gnu.org, busk <busk@lysator.liu.se>,
Daniel Koning <dk@danielkoning.com>
Subject: bug#6130: 23.1; artist-mode spray-can malfunction
Date: Fri, 23 Jan 2015 09:26:56 +0100 [thread overview]
Message-ID: <54C205D0.3000607@gmx.at> (raw)
In-Reply-To: <jwvfvb28lnv.fsf-monnier+emacsbugs@gnu.org>
> It's wrong for posn-window to return a frame.
Is it right for it to return nil? There seems to be no particular
restriction on what a "mouse position list" as returned by `event-start'
and `event-end' has to contain. Many callers simply use the selected
window or the window buffer of the selected window when the return value
of `posn-window' is nil.
> So are there callers that
> actually rely on this wrong behavior? Are there callers where returning
> nil instead of a frame would be a problem? Are there callers where
> signaling an error instead of returning a frame would be a problem?
`handle-delete-frame' seems to be the only function that expects
`posn-window' to return a frame (unconditionally, BTW). I don't
understand `handle-delete-frame' but it hardly will cause problems when
it gets nil or an error.
I didn't check for occurrences of things like "(nth 0 position".
>> This would backfire for people who would like `posn-window' to always
>> return the first element of a position.
>
> That's OK, in the sense that we don't care if people's feelings
> are hurt. But if it breaks existing packages it's more problematic.
If we really cared, we'd probably have to write something like
(defsubst posn-window (position)
"Return the window in POSITION.
POSITION should be a list of the form returned by the `event-start'
and `event-end' functions."
(if (window-live-p (nth 0 position))
(nth 0 position)
'none))
martin
next prev parent reply other threads:[~2015-01-23 8:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 12:17 bug#6130: 23.1; artist-mode spray-can malfunction busk
2015-01-17 5:25 ` Daniel Koning
2015-01-17 13:56 ` martin rudalics
2015-01-18 5:47 ` Daniel Koning
2015-01-18 9:57 ` martin rudalics
2015-01-21 0:26 ` Daniel Koning
2015-01-21 8:22 ` martin rudalics
2015-01-21 15:22 ` Stefan Monnier
2015-01-21 16:54 ` martin rudalics
2015-01-22 17:02 ` Stefan Monnier
2015-01-22 18:23 ` martin rudalics
2015-01-22 23:08 ` Stefan Monnier
2015-01-23 8:26 ` martin rudalics [this message]
2015-01-23 9:43 ` Eli Zaretskii
2015-01-23 16:54 ` martin rudalics
2015-01-23 21:05 ` Stefan Monnier
2015-01-23 21:26 ` Eli Zaretskii
2015-01-23 21:52 ` Daniel Koning
2015-01-24 8:12 ` Eli Zaretskii
2015-01-24 9:08 ` martin rudalics
2015-01-24 9:49 ` Eli Zaretskii
2016-04-06 9:17 ` Johan Busk Eriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C205D0.3000607@gmx.at \
--to=rudalics@gmx.at \
--cc=6130@debbugs.gnu.org \
--cc=busk@lysator.liu.se \
--cc=dk@danielkoning.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).