From: Dmitry Gutov <dgutov@yandex.ru>
To: martin rudalics <rudalics@gmx.at>, Eli Zaretskii <eliz@gnu.org>
Cc: 19466@debbugs.gnu.org, Helmut Eller <eller.helmut@gmail.com>
Subject: bug#19466: 25.0.50; xref-find-def doesn't find C functions
Date: Wed, 21 Jan 2015 21:02:28 +0200 [thread overview]
Message-ID: <54BFF7C4.9010500@yandex.ru> (raw)
In-Reply-To: <54BFD9AF.10002@gmx.at>
On 01/21/2015 06:54 PM, martin rudalics wrote:
> In any case please stick to the "`current' is a predicate for buffers
> and `selected' is a predicate for windows and frames" convention.
How about `visited'? The other precise alternative for that variable
named is `was-current'.
And considering that our main caller of that hook would be
`select-window', maybe the current name isn't too far from the mark?
> Are you sure? Suppose `xref-show-location-at-point' reused a window
> showing a buffer A for showing a buffer B instead. Now `xref-quit'
> would kill B which should again show A instead. But here you rely on
> `kill-buffer' (that is `replace-buffer-in-windows') DTRT.
Right, I do rely on kill-buffer doing what I'd expect. Anyway, I'm fine
with swapping the order, will do so soon.
> > You mean, for the user to switch to the buried xref buffer, then
> press C-u q? That's quite a few keypresses.
>
> Then you probably want the KILL argument for `xref-goto-xref' too.
Maybe. Wouldn't an option server this better?
We also allow jumping to a mouse click, and pressing C-u in that case
becomes more awkward.
> When xref prompts me with
>
> Find definitions of:
>
> I'd expect to be able to browse my history of definitions I tried or
> succeeded to find.
Ok, thanks. I'll look into input history.
next prev parent reply other threads:[~2015-01-21 19:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 19:27 bug#19466: 25.0.50; xref-find-def doesn't find C functions Eli Zaretskii
2014-12-30 4:57 ` Dmitry Gutov
2014-12-30 15:31 ` Eli Zaretskii
2014-12-30 18:05 ` Stefan Monnier
2014-12-30 18:25 ` Dmitry Gutov
2014-12-30 18:34 ` Eli Zaretskii
2014-12-30 18:38 ` Dmitry Gutov
2014-12-30 22:44 ` Stefan Monnier
2015-01-02 17:52 ` Dmitry Gutov
2015-01-04 20:10 ` Stefan Monnier
2015-01-04 20:29 ` Eli Zaretskii
2015-01-04 23:14 ` Dmitry Gutov
2015-01-05 3:36 ` Eli Zaretskii
2015-01-05 6:11 ` Stefan Monnier
2015-01-16 3:37 ` Dmitry Gutov
2015-01-16 7:47 ` martin rudalics
2015-01-16 9:04 ` Eli Zaretskii
2015-01-16 9:28 ` martin rudalics
2015-01-19 3:31 ` Dmitry Gutov
2015-01-19 8:28 ` martin rudalics
2015-01-19 13:32 ` Dmitry Gutov
2015-01-20 8:01 ` martin rudalics
2015-01-20 12:14 ` Dmitry Gutov
2015-01-20 14:51 ` martin rudalics
2015-01-21 7:20 ` Dmitry Gutov
2015-01-21 10:49 ` martin rudalics
2015-01-21 14:24 ` Dmitry Gutov
2015-01-21 16:54 ` martin rudalics
2015-01-21 18:00 ` martin rudalics
2015-01-21 20:02 ` Stefan Monnier
2015-01-22 2:32 ` Dmitry Gutov
2015-01-22 18:22 ` martin rudalics
2015-01-21 19:02 ` Dmitry Gutov [this message]
2015-01-22 2:26 ` Dmitry Gutov
2015-01-22 18:22 ` martin rudalics
2015-01-19 17:41 ` Eli Zaretskii
2015-01-20 2:54 ` Dmitry Gutov
2015-01-20 17:24 ` Eli Zaretskii
2015-01-20 20:49 ` Dmitry Gutov
2015-01-21 16:25 ` Eli Zaretskii
2015-01-22 2:43 ` Dmitry Gutov
2015-01-22 18:02 ` Eli Zaretskii
2015-01-22 21:02 ` Dmitry Gutov
2015-01-23 9:03 ` Eli Zaretskii
2015-01-23 17:34 ` Dmitry Gutov
2015-01-23 21:03 ` Eli Zaretskii
2015-01-23 22:23 ` Dmitry Gutov
2015-01-24 9:40 ` Eli Zaretskii
2015-01-24 16:47 ` Dmitry Gutov
2015-01-31 8:52 ` Eli Zaretskii
2015-02-01 2:24 ` Dmitry Gutov
2015-02-01 16:01 ` Eli Zaretskii
2015-02-01 20:11 ` Dmitry Gutov
2015-02-01 20:30 ` Eli Zaretskii
2015-02-01 20:53 ` Dmitry Gutov
2015-02-02 3:32 ` Eli Zaretskii
2015-02-23 2:01 ` Dmitry Gutov
2015-01-23 21:15 ` Stefan Monnier
2015-01-23 21:34 ` Eli Zaretskii
2015-01-16 9:00 ` Eli Zaretskii
2015-01-04 22:14 ` Dmitry Gutov
2014-12-30 20:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BFF7C4.9010500@yandex.ru \
--to=dgutov@yandex.ru \
--cc=19466@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).