unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Oleh Krehel <o.krehel@tue.nl>
Cc: 19493@debbugs.gnu.org
Subject: bug#19493: [PATCH] Fix trailing ... for outline-toggle-children
Date: Mon, 19 Jan 2015 06:14:32 +0200	[thread overview]
Message-ID: <54BC84A8.7030508@yandex.ru> (raw)
In-Reply-To: <CAJ1SQWAhEnUEQGQ6rn0SfEjqyDeOWgYj2FVBBWBo1GRmAtOLVA@mail.gmail.com>

On 01/16/2015 04:12 PM, Oleh Krehel wrote:

> You're right, I hadn't noticed before.
> Alternatively, `show-entry' can be patched like this:

That doesn't seem to be the full solution either. For instance, if the 
current heading has subheadings, with or without your patch "..." will 
remain at the end of the last of them.

Maybe the fix has to touch `show-children' as well. I'd hope to see a 
one-liner change that would fix both cases, though. :)

> The point is just not to have a single trailing hidden char, which
> results from passing different bounds to `outline-flag-region' when
> hiding and unhiding.

How come we pass different bounds? `show-entry' does pass a lower FROM 
bound than `hide-entry', but that should have this effect, should it? 
It's the TO bound that should make the difference.





  reply	other threads:[~2015-01-19  4:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03  0:04 bug#19493: [PATCH] Fix trailing ... for outline-toggle-children Oleh Krehel
     [not found] ` <handler.19493.B.142024344824250.ack@debbugs.gnu.org>
2015-01-16 10:07   ` bug#19493: Acknowledgement ([PATCH] Fix trailing ... for outline-toggle-children) Oleh Krehel
2015-01-16 13:32 ` bug#19493: [PATCH] Fix trailing ... for outline-toggle-children Dmitry Gutov
2015-01-16 14:12   ` Oleh Krehel
2015-01-19  4:14     ` Dmitry Gutov [this message]
2015-02-07 18:07       ` Oleh Krehel
2015-02-08  0:08         ` Dmitry Gutov
2016-02-23 11:27         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BC84A8.7030508@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=19493@debbugs.gnu.org \
    --cc=o.krehel@tue.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).