From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#6130: 23.1; artist-mode spray-can malfunction Date: Sun, 18 Jan 2015 10:57:09 +0100 Message-ID: <54BB8375.9000506@gmx.at> References: <8dd014e7478827e94e3a8fe5b2b948e0@lysator.liu.se> <54BA6A0A.4080408@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1421575110 11696 80.91.229.3 (18 Jan 2015 09:58:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Jan 2015 09:58:30 +0000 (UTC) Cc: 6130@debbugs.gnu.org, busk To: Daniel Koning Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 18 10:58:30 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YCmcm-0000n5-Om for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jan 2015 10:58:29 +0100 Original-Received: from localhost ([::1]:33109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCmcm-0006lN-5Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Jan 2015 04:58:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCmcP-0006Oo-Qw for bug-gnu-emacs@gnu.org; Sun, 18 Jan 2015 04:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCmcM-000090-LT for bug-gnu-emacs@gnu.org; Sun, 18 Jan 2015 04:58:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCmcM-00006N-IU for bug-gnu-emacs@gnu.org; Sun, 18 Jan 2015 04:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YCmcM-000139-1t for bug-gnu-emacs@gnu.org; Sun, 18 Jan 2015 04:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jan 2015 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6130-submit@debbugs.gnu.org id=B6130.14215750523993 (code B ref 6130); Sun, 18 Jan 2015 09:58:01 +0000 Original-Received: (at 6130) by debbugs.gnu.org; 18 Jan 2015 09:57:32 +0000 Original-Received: from localhost ([127.0.0.1]:60518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCmbr-00012L-UY for submit@debbugs.gnu.org; Sun, 18 Jan 2015 04:57:32 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:52252) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCmbp-000122-Re for 6130@debbugs.gnu.org; Sun, 18 Jan 2015 04:57:30 -0500 Original-Received: from [88.117.58.166] ([88.117.58.166]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LwXCt-1Xg3Ju2i9n-018GcD; Sun, 18 Jan 2015 10:57:21 +0100 In-Reply-To: X-Provags-ID: V03:K0:f5q0wsS0Oz9vBUM/b44kPwnRROhX9kIeM/9rPHVeZexYq2e6jwj nO8O/Ov0e4bNhFQEgKNvLMuyNVdQxrUadBrgS/mKf1rbziZbaqr7hx/8GfmM5JamTfKSRhZ Gzio+QgBiyk31Qn0OKUmi8yBoXMHszKbx+yoK5MrnHDNG8MgdCw20N2cmoqew8+3byVQvxc lZNDZm6nm8nAV3BokOleA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98451 Archived-At: > I've put in a request. I'll write back when I've received and returned > the form. Thanks. It usually takes some time and it might be a good idea to complain after a few weeks in order to speed things up. >> `posnp' also looks strange in this regard. >> > > It does indeed, and I added a line to check for frames. No - this might be dangerous for now. Suppose we have callers that relied on `posnp' to return nil in that case. They would all of sudden have to deal with the fact that they get a frame now, so more or less we could reintroduce the problem you try to fix presently. Please take this out for the moment but state in the doc-string that `posnp' returns nil if the first element of OBJ is a frame. Later on we can change this as you did and see what happens. > That said, I don't *think* it's ever possible in practice to change the > selected frame in the middle of a drag event through user interaction > alone -- either implicitly or by a keypress bound to `other-frame'. I'm > basing this on having just tried it in several window systems on both OS > X and BSD, including with focus-follows-mouse behavior enabled (and with > the corresponding Emacs variable turned on). I was only able to test it > by means of an event-reading loop which programmatically called > `other-frame' after every down-mouse event. Fine. I suppose it would defeat the purpose of mouse dragging if the selected frame could ever change in between but wanted to make sure. Here I was not able to produce a frame select event either. > Come to think of it, this is wrong either way, because the implication > of "the frame with input focus" is the frame with input focus at the > time of evaluation, whereas the position list reflects the state at the > time it was generated. > > How about: "If @var{position} represents a location outside the frame > where the event was initiated, [...]" Good. >> (frame-selected-window frame) >> >> sounds more accurate, given what I said about the selected frame above. > > I haven't changed these lines except for taking them out of a > now-superfluous let*, but I agree that they look wrong. (Technically > `window' is either the window from the position list or nil. If it is > nil, though, `window-buffer' does return the buffer of the selected > window. The calculation should be made w/r/t the selected window of the > position list's frame, so I'll make that change.) OK. Given your observations above it should not matter. >>> diff --git a/lisp/textmodes/artist.el b/lisp/textmodes/artist.el >> >> I didn't look into these but just trust your experience here. > > This one looks like a major change because of all the diffed lines, but > that's just due to adding an extra layer of indentation. The only > semantic change is wrapping the `track-mouse' form in an `unwind-protect'. Ahh. I didn't notice. In that case we could commit your patch as a tiny change. > Here's the revised patch. Looks good. Please fix the `posnp' thingy I mentioned above, add some ChangeLog entries and resend the patch as an attachment. If there are no objections I'll commit it then to the emacs-24 branch. Thanks, martin