From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Date: Fri, 16 Jan 2015 05:36:57 +0300 Message-ID: <54B87949.4040402@yandex.ru> References: <86wq7ai5cz.fsf@yandex.ru> <4fd05af1b84870c40eae10fa421aa17c@samertm.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1421375892 12951 80.91.229.3 (16 Jan 2015 02:38:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Jan 2015 02:38:12 +0000 (UTC) Cc: 18950-done@debbugs.gnu.org To: Stefan Monnier , samer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 16 03:38:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YBwna-0004u4-OW for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jan 2015 03:38:10 +0100 Original-Received: from localhost ([::1]:53741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBwna-0007LJ-3J for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Jan 2015 21:38:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBwnW-0007L9-Ts for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 21:38:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBwnS-00049Q-TL for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 21:38:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBwnS-00049J-QJ for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 21:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YBwnS-00035n-Cz for bug-gnu-emacs@gnu.org; Thu, 15 Jan 2015 21:38:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jan 2015 02:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 18950@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 18950-done@debbugs.gnu.org id=D18950.142137583211826 (code D ref 18950); Fri, 16 Jan 2015 02:38:01 +0000 Original-Received: (at 18950-done) by debbugs.gnu.org; 16 Jan 2015 02:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:58311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBwme-00034g-3g for submit@debbugs.gnu.org; Thu, 15 Jan 2015 21:37:12 -0500 Original-Received: from mail-la0-f51.google.com ([209.85.215.51]:58027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBwmb-00034R-CF for 18950-done@debbugs.gnu.org; Thu, 15 Jan 2015 21:37:09 -0500 Original-Received: by mail-la0-f51.google.com with SMTP id ms9so16818182lab.10 for <18950-done@debbugs.gnu.org>; Thu, 15 Jan 2015 18:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=+BUI5BslXWqMbMwT79xDs+0z1N1rrrxGWujYWuPXVhk=; b=dFtJrwjWQ3otykoiqtmtRnVehHUvARkFNM4I8o3h5u/D/NsdW2/wBHOkNFE/iulg75 sTGxMFL99O0+94zEvJHOiorcw//RpVhWfRi5OaMPACuPVo12mE+XTtIMtXWa9QyyqQW+ DBJ7c1RZ0h4tOnoQPwaCihC0Z3XQiL9S27kLcGKRq8OzZ5Wu9LgCf2d300R8yYRG7b/C FxD79KPJmYQXEgTxTpYN0KKfkGLEo/nBISxcv+r+KqWs419Q1wKZKEKpqMEnOV7Y8gse KC3FHL9Y9hF0JVPYMCy6hjMhzUbxHk93KmAQOqRgFVX50ox23isDSpttps3UW9mIS103 y8dA== X-Received: by 10.152.19.7 with SMTP id a7mr13131326lae.16.1421375823312; Thu, 15 Jan 2015 18:37:03 -0800 (PST) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id e7sm477002lbq.33.2015.01.15.18.37.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 18:37:02 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98399 Archived-At: On 01/15/2015 06:06 PM, Stefan Monnier wrote: >> - (if (and pcomplete-cycle-completions >> - (listp pcomplete-stub) ;?? >> + (if (and (listp pcomplete-stub) ;?? > > I haven't had time to look more closely at the bug and the code, but > if this indeed works, then it looks like a good change. It does. Installed and marked as "tiny change". Thanks, Samer!