From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, samer <samer@samertm.com>
Cc: 18950-done@debbugs.gnu.org
Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled
Date: Fri, 16 Jan 2015 05:36:57 +0300 [thread overview]
Message-ID: <54B87949.4040402@yandex.ru> (raw)
In-Reply-To: <jwvmw5kw0bs.fsf-monnier+emacsbugs@gnu.org>
On 01/15/2015 06:06 PM, Stefan Monnier wrote:
>> - (if (and pcomplete-cycle-completions
>> - (listp pcomplete-stub) ;??
>> + (if (and (listp pcomplete-stub) ;??
>
> I haven't had time to look more closely at the bug and the code, but
> if this indeed works, then it looks like a good change.
It does. Installed and marked as "tiny change".
Thanks, Samer!
prev parent reply other threads:[~2015-01-16 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 5:27 bug#18950: 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Dmitry Gutov
2015-01-15 4:12 ` bug#18950: [PATCH] " samer
2015-01-15 15:06 ` Stefan Monnier
2015-01-16 2:36 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B87949.4040402@yandex.ru \
--to=dgutov@yandex.ru \
--cc=18950-done@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=samer@samertm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).