From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Olivier Certner Newsgroups: gmane.emacs.bugs Subject: bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Date: Thu, 25 Feb 2021 18:33:53 +0100 Message-ID: <5495728.XOh7uYVVfo@ravel> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37832"; mail-complaints-to="usenet@ciao.gmane.io" To: 46777@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 25 18:35:52 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFKYI-0009iV-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Feb 2021 18:35:50 +0100 Original-Received: from localhost ([::1]:49124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFKYH-0000Ib-MP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Feb 2021 12:35:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFKXW-0000IO-FR for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 12:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFKXW-0004nq-7z for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 12:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFKXW-0005vW-4Q for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 12:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Olivier Certner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Feb 2021 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46777 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161427444222710 (code B ref -1); Thu, 25 Feb 2021 17:35:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Feb 2021 17:34:02 +0000 Original-Received: from localhost ([127.0.0.1]:39157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFKWY-0005uE-Es for submit@debbugs.gnu.org; Thu, 25 Feb 2021 12:34:02 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFKWV-0005to-Bd for submit@debbugs.gnu.org; Thu, 25 Feb 2021 12:34:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFKWV-0000Be-1Y for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 12:33:59 -0500 Original-Received: from smtp6-g21.free.fr ([2a01:e0c:1:1599::15]:50674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFKWT-0004MM-5d for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 12:33:58 -0500 Original-Received: from ravel.localnet (unknown [90.118.181.206]) (Authenticated sender: ocert.dev@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 930EB78032A for ; Thu, 25 Feb 2021 18:33:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1614274434; bh=mM5YnwtlAsp8uz8Pz3JS+HBfIDIYGdVIaPZcgGQtkXE=; h=From:To:Subject:Date:From; b=IgJYN+kyam/UWP3VVidAX11dA1MQRSI49d8AmTap6DoHiH74vq/j/OY3OdtVWbauk 9HNQLXrv1dnP9JYbPInm1om7h7vQJE1SgZY7aXtsSkL2DVm+30P/vWGE9XASTpTBQ4 UZuUF2A0roEXAXm0FZi/ff6sKb+xI12fRf9ws/51VtJ2OFya3K7rwOw8WBY+0WzpKR Y4Xga946uJEKPeucKCF8t4UBRQz4hlZvsmE4deZUibXIAFaueLPrAPFNBrCoKeOFxn 6R7vND5zx/oC2qtByCpeW8fA+UoySosf8QjDc8Ld+Cj0F8YPQULpVECx2WZz4FZk0c Dw2x8VQ3rDRiw== Received-SPF: pass client-ip=2a01:e0c:1:1599::15; envelope-from=ocert.dev@free.fr; helo=smtp6-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200800 Archived-At: When `erc-prompt-for-nickserv-password' is true, don't ignore the other forms of identification. Instead, process them first, and prompt for the password last. Separate concerns (determination of the nick to use, of the password to use, and actual message sending). Note that the user can be interactively prompted for a password on reception of a Nickserv request, as before (on `erc-prompt-for-nickserv-password'). This is a follow-up to #45340 (see end of discussion there for additional context). Pull request with the single commit to be posted after the bug is open. Changes rebased on master. -- Olivier Certner