From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19390: 25.0.50; `package-activate' is too slow Date: Thu, 18 Dec 2014 17:45:16 +0200 Message-ID: <5492F68C.3090700@yandex.ru> References: <86a92oddfp.fsf@yandex.ru> <86mw6nkc6n.fsf@yandex.ru> <54904241.8010000@yandex.ru> <5490BFCD.5050505@yandex.ru> <5490ED6D.5080808@yandex.ru> <868ui5ervl.fsf@yandex.ru> <5492AE61.3040902@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1418917590 23887 80.91.229.3 (18 Dec 2014 15:46:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Dec 2014 15:46:30 +0000 (UTC) Cc: 19390@debbugs.gnu.org To: bruce.connor.am@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 18 16:46:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y1dHT-0001zG-4V for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Dec 2014 16:46:23 +0100 Original-Received: from localhost ([::1]:54501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1dHS-0002L7-2f for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Dec 2014 10:46:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1dHG-0002Kw-Ha for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2014 10:46:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1dH8-0000Nr-Rb for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2014 10:46:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1dH8-0000Na-Nk for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2014 10:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y1dH8-0002HU-4T for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2014 10:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Dec 2014 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19390-submit@debbugs.gnu.org id=B19390.14189175228714 (code B ref 19390); Thu, 18 Dec 2014 15:46:02 +0000 Original-Received: (at 19390) by debbugs.gnu.org; 18 Dec 2014 15:45:22 +0000 Original-Received: from localhost ([127.0.0.1]:50240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1dGT-0002GT-Us for submit@debbugs.gnu.org; Thu, 18 Dec 2014 10:45:22 -0500 Original-Received: from mail-wi0-f176.google.com ([209.85.212.176]:46905) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y1dGR-0002GL-P7 for 19390@debbugs.gnu.org; Thu, 18 Dec 2014 10:45:20 -0500 Original-Received: by mail-wi0-f176.google.com with SMTP id ex7so2193680wid.15 for <19390@debbugs.gnu.org>; Thu, 18 Dec 2014 07:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=tSVOsy5Jf8NxPp7BQNi6Icn0Z+JU/GbQg7y8q4E0C8A=; b=QF3tKHietL2qJkSGSdjOh3ymH7vxrmJG3/Jn+MatI4VcYtviKlZi1rI4nEtvhTjPnB GMN73yZx7r/Uh1GS/Fnhlkr8LYRBM/jRz9C7cKzUx6A/tQeodZ3GgeHkDfU72vsHREyp fjPWk8AX518v5tV58UVOtA0dwbO87dGv0g2QzR2EW2nDFjdd4LHSzlrJNRXtXNxnmYpv 0li0nbYypKFG3SVXdNA5movLXjkGYKMNKhqH6Qv4s2Dzs0+4y+3jurDXoDHetFYuhEND yCQbPC1vFIr+jNxlCK9MTvg7ylCDVsMDpYWQp+cQrjkNwNA3K1bxzPhNX/1Jq4NirZK2 KT4Q== X-Received: by 10.194.48.109 with SMTP id k13mr5735342wjn.7.1418917518809; Thu, 18 Dec 2014 07:45:18 -0800 (PST) Original-Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id bs2sm9354490wjc.43.2014.12.18.07.45.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Dec 2014 07:45:18 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97510 Archived-At: On 12/18/2014 05:15 PM, Artur Malabarba wrote: > There's a bit of a small flaw with that approach, it's the reason I used > find-library. > If you just check load files against their names, you could find a wrong > file that has the same name as a feature (we require files in the load > path to be uniquely named, but load-history contains all files, not just > those in the load path). Like mentioned, we can also check against the `provide' values in each load-history element we find matching. Shouldn't be a perceptible performance hit. > It's an edge case, and my opinion is that a good performance improvement > is more important than that. But it seems like the 2 biggest performance > improvements have already been made (the package initialize, and the > file true name), so I wonder if it's worth it. 200ms per package initialization still seems a lot to me (even if it's only for certain packages). I also happen to think that the suggested code is a bit easier to understand, but it's up to you.