From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19390: 25.0.50; `package-activate' is too slow Date: Tue, 16 Dec 2014 16:31:29 +0200 Message-ID: <54904241.8010000@yandex.ru> References: <86a92oddfp.fsf@yandex.ru> <86mw6nkc6n.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1418740350 7713 80.91.229.3 (16 Dec 2014 14:32:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Dec 2014 14:32:30 +0000 (UTC) Cc: 19390@debbugs.gnu.org To: bruce.connor.am@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 16 15:32:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0tAj-0001ug-Tc for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Dec 2014 15:32:22 +0100 Original-Received: from localhost ([::1]:45091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0tAj-0007A0-G8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Dec 2014 09:32:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0tAY-000796-Di for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 09:32:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0tAQ-0003uO-PE for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 09:32:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0tAQ-0003uK-M8 for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 09:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y0tAQ-0002Lr-9E for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 09:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Dec 2014 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19390-submit@debbugs.gnu.org id=B19390.14187402969004 (code B ref 19390); Tue, 16 Dec 2014 14:32:02 +0000 Original-Received: (at 19390) by debbugs.gnu.org; 16 Dec 2014 14:31:36 +0000 Original-Received: from localhost ([127.0.0.1]:47638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0t9z-0002L9-UE for submit@debbugs.gnu.org; Tue, 16 Dec 2014 09:31:36 -0500 Original-Received: from mail-wi0-f182.google.com ([209.85.212.182]:41456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0t9x-0002L0-Ih for 19390@debbugs.gnu.org; Tue, 16 Dec 2014 09:31:33 -0500 Original-Received: by mail-wi0-f182.google.com with SMTP id h11so12641316wiw.15 for <19390@debbugs.gnu.org>; Tue, 16 Dec 2014 06:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=LYtG2Y5CShatNxa7RreBEm0B6rmPySogmBfKcGIfbPM=; b=L0KUreeN2YoIfCq7sMdKtLrl87izVuSCVbnsY76ZPJ4LUbNbDBNK7wBEz1hC6M0qj2 j835SUQhmAaQuyzdUVAKctpKksfcp8e/U/3bkF/Hxv+mCFi+PEZib85dSz6KQ+yfRReI DB/rGlhvWsplv7YmpvdT1+pMBKQcIjwXSj0WiNFxVO8+4UeKqPBBXT4/n1SrmBAUc1Pj Hq94SgP5Xr3l/asdqewCaCMR+syVYLbQ2OhkSvqxyTZkfG9vTG2AY5KfvntsGhDAbDTG p1nHbtHQlFdERxQzsmhLtTUC454qkFbjU/UEtkonDtCOB+rPCZi8BcRksppxpV9VnjYW aIIg== X-Received: by 10.180.91.37 with SMTP id cb5mr5342805wib.1.1418740291485; Tue, 16 Dec 2014 06:31:31 -0800 (PST) Original-Received: from [192.168.1.2] ([82.102.93.58]) by mx.google.com with ESMTPSA id s9sm2344084wiz.12.2014.12.16.06.31.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 06:31:30 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97383 Archived-At: On 12/16/2014, Artur Malabarba wrote: > I didn't notice anything as aggravating as the report, but I agree my > latest patch is a performance concern. Do you maybe have fewer packages installed? > avoid a lot of > calls to `file-truename'. This, I suspect, is the bigger performance > issue. Any particular reason you're using `file-truename', instead of `expand-file-name'? Replacing the former with the latter already gives ~twofold performance improvement. > 2. Creating the `history' variable as below is a problem. > > (mapcar (lambda (x) (file-name-sans-extension > (file-truename (car x)))) > load-history) With the above change, this piece of code is relatively fast. For instance, (package--list-loaded-files default-directory) in the Helm directory takes 140 ms here, whereas (mapcar (lambda (x) (file-name-sans-extension (expand-file-name (car x)))) load-history) only takes ~10 ms. Still not fast enough not to need the other patch, of course.