unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Daniel Colascione" <dancol@dancol.org>
To: "Noam Postavsky" <npostavs@gmail.com>
Cc: "Clément Pit-Claudel" <clement.pitclaudel@live.com>,
	"Philipp Stephani" <p.stephani2@gmail.com>,
	30964@debbugs.gnu.org
Subject: bug#30964: python-mode failing "overlapping strings" assertion lately
Date: Sat, 16 Jun 2018 13:55:49 -0700	[thread overview]
Message-ID: <5481253d38230797b677df41cf507790.squirrel@dancol.org> (raw)
In-Reply-To: <87muwd9ba1.fsf@gmail.com>

So it turns out that it wasn't an off-by-one problem at all.  Instead,
python was using (re-search-forward (rx (syntax string-delimiter))), which
was matching incorrectly because re-search-forward didn't update syntax as
it matched. It didn't do that because regex matching in general wasn't
reentrant, and it wasn't reentrant because regex bytecode programs are
self-modifying.

I checked in some work that makes regex searching update syntax as needed.






  reply	other threads:[~2018-06-16 20:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 18:09 bug#30964: python-mode failing "overlapping strings" assertion lately dancol
2018-04-02  1:11 ` Noam Postavsky
2018-04-03 18:12 ` Charles A. Roelli
2018-04-03 22:06   ` Dmitry Gutov
2018-05-18 15:46 ` Clément Pit-Claudel
2018-05-18 19:18   ` Andreas Röhler
2018-05-19  1:49     ` Noam Postavsky
2018-05-19  6:49       ` Andreas Röhler
2018-05-30  0:29   ` Noam Postavsky
2018-06-02 19:03     ` Philipp Stephani
2018-06-02 20:35       ` Noam Postavsky
2018-06-16 20:55         ` Daniel Colascione [this message]
2018-06-16 22:36           ` Noam Postavsky
2018-06-17  7:33             ` Andreas Röhler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5481253d38230797b677df41cf507790.squirrel@dancol.org \
    --to=dancol@dancol.org \
    --cc=30964@debbugs.gnu.org \
    --cc=clement.pitclaudel@live.com \
    --cc=npostavs@gmail.com \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).