From: martin rudalics <rudalics@gmx.at>
To: Joe Corneli <holtzermann17@gmail.com>
Cc: 19194@debbugs.gnu.org
Subject: bug#19194: 24.4.50; `window-body-width' is not dynamic relative to font size changes
Date: Thu, 27 Nov 2014 19:35:25 +0100 [thread overview]
Message-ID: <54776EED.9090303@gmx.at> (raw)
In-Reply-To: <87ppc8rk08.fsf@gmail.com>
> I think you are totally right. To keep the buffer and window
> distinction properly, my note should probably be read as a feature
> request, not a bug report. The request is for a function such as
> `buffer-body-width' that would return the width of the current displayed
> buffer in em-length units.
What is the width of a buffer? What are em-lenght units?
> Sounds promising! I just pressed C-x C-- which runs `text-scale-adjust'
> to the effect: "Decrease the default face height by one step".
That's incorrect. The doc-string of `text-scale-decrease' tells it more
accurately: "Decrease the height of the default face in the current
buffer by DEC steps."
> The step
> is `text-scale-mode-step', unchanged from its default value of 1.2. The
> number of steps looks to be stored buffer-locally as
> `text-scale-mode-amount'.
>
> ... So a candidate function would be:
>
> (defun buffer-body-width (&optional buffer pixelwise)
> (let ((width (window-body-width (get-buffer-window (or buffer
> (current-buffer)))
> pixelwise)))
> (floor (cond
> ((eq text-scale-mode-amount 0)
> width)
> ((> text-scale-mode-amount 0)
> (/ width (* text-scale-mode-step text-scale-mode-amount)))
> ((< text-scale-mode-amount 0)
> (* width (* -1 text-scale-mode-step text-scale-mode-amount)))))))
We could start from here. But:
(1) `text-scale-mode-amount' is not autoloaded, so we get an error
calling this with emacs -Q.
(2) `text-scale-mode-amount' is buffer-local. So we have to choose the
right buffer before evaluating it.
(3) `text-scale-mode-amount' constitutes a request to the display engine
to scale a face height. What shall we do when our target machine
can't display the character with the requested height and uses, for
example, the nearest available height instead?
(4) I don't know whether and how the frame's `font' parameter can/should
affect the height of the "default face". Likely this is not a
problem - Eli will tell.
As I said before, I'd rather have a buffer-local equivalent of the
variable `frame-char-height', something like `buffer-char-height',
instead of having to find out by myself what the correct value is.
Next we should try to incorporate this in `window-body-height', either
by overloading the PIXELWISE argument - for example, if this is the
symbol `lines-scaled' we'd return the scaled lines - or with an extra
BUFFER argument which would also allow to retrieve the body height of a
window as if it displayed BUFFER or with something better yet ...
As a consequence, we'd probably have to rename the current C routine
`window-body-height' to `window-body-height-internal' and write the new
`window-body-height' in Elisp on top of that.
And finally we would have to do that for all related functions like
`window-total-height', `split-window' or `window-resize' and decide how
a user can specify that, when splitting a window via say C-4 C-x 2, the
top window should have four lines counted in the original window
buffer's text scaling.
martin
next prev parent reply other threads:[~2014-11-27 18:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 13:47 bug#19194: 24.4.50; `window-body-width' is not dynamic relative to font size changes Joe Corneli
2014-11-26 15:55 ` Stefan Monnier
2014-11-26 16:34 ` Joe Corneli
2014-11-26 17:06 ` Eli Zaretskii
2014-11-26 16:04 ` Eli Zaretskii
2014-11-27 9:44 ` martin rudalics
2014-11-27 10:54 ` Joe Corneli
2014-11-27 18:35 ` martin rudalics [this message]
2014-11-27 18:52 ` Eli Zaretskii
2014-11-27 19:58 ` martin rudalics
2014-11-27 20:43 ` Eli Zaretskii
2014-11-28 7:29 ` martin rudalics
2014-11-28 8:49 ` Eli Zaretskii
2014-11-28 18:38 ` martin rudalics
2014-11-28 19:20 ` Eli Zaretskii
2014-12-19 19:40 ` Eli Zaretskii
2014-12-20 10:10 ` martin rudalics
2014-12-20 11:52 ` Joe Corneli
2014-12-20 14:49 ` martin rudalics
2014-12-20 16:18 ` Eli Zaretskii
2014-12-20 16:31 ` martin rudalics
2014-12-20 16:47 ` Eli Zaretskii
2014-12-20 17:51 ` martin rudalics
2014-12-20 18:29 ` Eli Zaretskii
2014-11-27 20:23 ` Joe Corneli
2014-11-28 7:27 ` martin rudalics
2014-11-27 16:17 ` Eli Zaretskii
2014-11-27 18:35 ` martin rudalics
2014-11-27 18:46 ` Eli Zaretskii
2014-11-27 19:58 ` martin rudalics
2014-11-27 20:37 ` Eli Zaretskii
2014-11-28 7:27 ` martin rudalics
2014-11-28 8:42 ` Eli Zaretskii
2022-02-10 8:16 ` bug#19194: bug#20022: 24.4.90; window-body-height, window-body-width wrong value after text-scale-adjust Lars Ingebrigtsen
2022-02-10 17:39 ` bug#19194: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54776EED.9090303@gmx.at \
--to=rudalics@gmx.at \
--cc=19194@debbugs.gnu.org \
--cc=holtzermann17@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).