unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Steve Purcell <steve@sanityinc.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 19972@debbugs.gnu.org
Subject: bug#19972: Font size change doesn't update (window-total-width)
Date: Mon, 2 Mar 2015 17:23:58 +0000	[thread overview]
Message-ID: <547071A4-097B-43D7-8C8E-F65107A68E6C@sanityinc.com> (raw)
In-Reply-To: <54F4998B.40507@gmx.at>

On 2 Mar 2015, at 17:10, martin rudalics <rudalics@gmx.at> wrote:
> 
> > - Consider the case of full-screen frames, which never change in pixel
> >   size. The window-width should change when the font size changes in
> >   this case too.
> 
> This is the case (hopefully) with Emacs 25 but not with Emacs 24.5.
> Although some window managers may refuse to change the frame size even
> with Emacs 24.5 as we've learned here.



It’s not the case on OS X with Emacs HEAD from 19th Feb, at least.



> > - set-frame-font is a built-in function with a KEEP-SIZE param which
> >   tells it to try to preserve the pixel-size of the frame after the
> >   font has changed: my code is copied from there.
> 
> If you look at the implementation of this you will see that it first
> resizes the frame (via x_new_font) and then tries to size it back to the
> original size.  This will fail miserably when the frame was maximized
> before (because maximization is a state and not just a specific size)
> and will fail when the frame size was not an integral multiple of its
> default character size (because `set-frame-font' does some strange
> rounding).  So never ever use `set-frame-font' with KEEP-SIZE non-nil.
> With Emacs 25 you can do, for example,
> 
> (let ((frame-inhibit-implied-resize t))
>  (custom-push-theme 'theme-face 'default 'user 'set '((t (:height 128))))
>  (face-spec-recalc 'default (selected-frame)))
> 
> unless you have set `frame-inhibit-implied-resize' to non-nil already.


Interesting: I hadn’t seen that. The above snippet still results in a changed frame size on my system, though.






  reply	other threads:[~2015-03-02 17:23 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01  2:31 bug#19972: 24.4; Font size change doesn't update (window-total-width) Joost Kremers
2015-03-01 15:14 ` martin rudalics
2015-03-01 15:28   ` Eli Zaretskii
2015-03-01 15:54     ` martin rudalics
2015-03-01 17:07     ` Joost Kremers
2015-03-01 17:46       ` Eli Zaretskii
2015-03-01 20:43         ` Joost Kremers
2015-03-02  3:30           ` Eli Zaretskii
2015-03-02  3:59             ` Joost Kremers
2015-03-02 14:04               ` Eli Zaretskii
2015-03-02 17:08                 ` martin rudalics
2015-03-02 17:35                   ` Eli Zaretskii
2015-03-02 18:12                     ` martin rudalics
2015-03-02 18:25                       ` Eli Zaretskii
2015-03-02 18:43                         ` martin rudalics
2015-03-02 18:46                           ` Eli Zaretskii
2015-03-02 22:26                 ` Joost Kremers
2015-03-03  3:36                   ` Eli Zaretskii
2015-03-03  8:07                     ` martin rudalics
2015-03-03  9:06                       ` Jan Djärv
2015-03-03 10:17                         ` martin rudalics
2015-03-03 11:05                           ` Jan D.
2015-03-03 11:26                             ` martin rudalics
2015-03-03 12:08                               ` Jan D.
2015-03-03 12:08                     ` Joost Kremers
2015-03-03  8:06                   ` martin rudalics
2015-03-02 17:08           ` martin rudalics
2015-03-02 17:07         ` martin rudalics
2015-03-02 17:06       ` martin rudalics
2015-03-01 17:06   ` Joost Kremers
2015-03-02  3:18   ` Joost Kremers
2015-03-02 17:09     ` martin rudalics
2015-03-02 17:24       ` Eli Zaretskii
2015-03-02 18:12         ` martin rudalics
2015-03-02 18:26           ` Eli Zaretskii
2015-03-03 10:38       ` martin rudalics
2015-03-03 12:23         ` Joost Kremers
2015-03-04 15:10           ` martin rudalics
2017-10-02  8:48             ` martin rudalics
2015-03-02  7:57 ` bug#19972: " Steve Purcell
2015-03-02 13:27   ` Eli Zaretskii
2015-03-02 14:07     ` Steve Purcell
2015-03-02 14:09       ` Steve Purcell
2015-03-02 14:24         ` Eli Zaretskii
2015-03-02 17:37         ` Jan D.
2015-03-02 14:23       ` Eli Zaretskii
2015-03-02 17:42     ` Jan D.
2015-03-02 17:56       ` Eli Zaretskii
2015-03-02 19:06         ` Jan D.
2015-03-02 19:52           ` Eli Zaretskii
2015-03-02 20:19             ` Jan D.
2015-03-03 16:11               ` Eli Zaretskii
2015-03-03 17:47                 ` martin rudalics
2015-03-03 18:02                   ` Eli Zaretskii
2015-03-03 18:36                     ` martin rudalics
2015-03-03 18:38                       ` Eli Zaretskii
2015-03-04 15:10                         ` martin rudalics
2015-03-04 17:47                           ` Eli Zaretskii
2015-03-04 18:45                             ` martin rudalics
2015-03-04 18:59                               ` Eli Zaretskii
2015-03-04 19:25                                 ` Jan D.
2015-03-05  8:06                                 ` martin rudalics
2015-03-05 16:34                                   ` Eli Zaretskii
2015-03-05 18:14                                     ` martin rudalics
2015-03-05 20:22                                       ` Eli Zaretskii
2015-03-05 21:15                                         ` martin rudalics
2015-03-06  8:09                                           ` Eli Zaretskii
2015-03-06  9:21                                             ` martin rudalics
2015-03-06 10:58                                               ` Eli Zaretskii
2015-03-02 14:44   ` Drew Adams
2015-03-02 15:02     ` Steve Purcell
2015-03-02 17:10   ` martin rudalics
2015-03-02 17:23     ` Steve Purcell [this message]
2015-03-02 18:12       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547071A4-097B-43D7-8C8E-F65107A68E6C@sanityinc.com \
    --to=steve@sanityinc.com \
    --cc=19972@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).