From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Date: Sat, 15 Nov 2014 13:12:47 +0100 Message-ID: <5467433F.4020906@gmx.at> References: <83wq6wg6fq.fsf@gnu.org> <5467354D.3000600@gmx.at> <83lhncg1b8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1416053668 27412 80.91.229.3 (15 Nov 2014 12:14:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Nov 2014 12:14:28 +0000 (UTC) Cc: kelly@prtime.org, 19060@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 15 13:14:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XpcFA-0000rZ-Tc for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Nov 2014 13:14:21 +0100 Original-Received: from localhost ([::1]:40004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpcFA-0005pm-8w for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Nov 2014 07:14:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpcEz-0005pc-SZ for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 07:14:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XpcEs-0004Eb-Dm for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 07:14:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XpcEs-0004EX-BR for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 07:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XpcEs-0000Xn-4L for bug-gnu-emacs@gnu.org; Sat, 15 Nov 2014 07:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Nov 2014 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19060-submit@debbugs.gnu.org id=B19060.14160535832009 (code B ref 19060); Sat, 15 Nov 2014 12:14:02 +0000 Original-Received: (at 19060) by debbugs.gnu.org; 15 Nov 2014 12:13:03 +0000 Original-Received: from localhost ([127.0.0.1]:33303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpcDu-0000WL-Lr for submit@debbugs.gnu.org; Sat, 15 Nov 2014 07:13:02 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:53022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XpcDq-0000Vu-Rt for 19060@debbugs.gnu.org; Sat, 15 Nov 2014 07:13:00 -0500 Original-Received: from [178.190.161.208] ([178.190.161.208]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MPDeK-1Xu24d2MiW-004RQi; Sat, 15 Nov 2014 13:12:55 +0100 In-Reply-To: <83lhncg1b8.fsf@gnu.org> X-Provags-ID: V03:K0:QCz8AFgtSqUBzVsIcog74mUZgJImwLwBUR2O7KXraVyKK69xNTK rEEb7//5A9ci4Eft8l4VE4Kzk3BM6bZEFtuzRlxFm6cY4yXPiQsTpUfIRgWHW9WfuEr6Isb z/VpV1ODhBqe3uJ4x8M4P/RGQVFyDaigBcbUsC9pGAXk32wYh979kkbJsKdSiNx/Q4ZCYs1 9EQhNcVntRVEgunGgvayQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96056 > Yes. Why is it hard to understand? When I try to correct an off-by-one error I usually never understand what I'm doing. I "fix" it by rounding in one direction first and if this doesn't seem to work as intended I try the other direction. >> Could you add comments which tell more or less how you corrected the >> issue? > > Will do, once we agree that this is the right fix. First of all I'd need to understand the bug itself. Do we assume that scrolling down is "correct" in some sense or does the bug manifest itself there already? Does scrolling up always move to the line before the "previously established as correct" one or to the line after it? (I'm asking because I cannot reproduce the problem with Kelly Dean's pgup/pgdn recipe.) martin