From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kelly@prtime.org, 19060@debbugs.gnu.org
Subject: bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based
Date: Sat, 15 Nov 2014 13:12:47 +0100 [thread overview]
Message-ID: <5467433F.4020906@gmx.at> (raw)
In-Reply-To: <83lhncg1b8.fsf@gnu.org>
> Yes. Why is it hard to understand?
When I try to correct an off-by-one error I usually never understand
what I'm doing. I "fix" it by rounding in one direction first and if
this doesn't seem to work as intended I try the other direction.
>> Could you add comments which tell more or less how you corrected the
>> issue?
>
> Will do, once we agree that this is the right fix.
First of all I'd need to understand the bug itself. Do we assume that
scrolling down is "correct" in some sense or does the bug manifest
itself there already? Does scrolling up always move to the line before
the "previously established as correct" one or to the line after it?
(I'm asking because I cannot reproduce the problem with Kelly Dean's
pgup/pgdn recipe.)
martin
next prev parent reply other threads:[~2014-11-15 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <emacs-mail-is-unusable-4@[87.69.4.28]>
2014-11-15 9:27 ` bug#19060: [FIX INCLUDED] Off-by-one-line scrolling bug in window_scroll_pixel_based Eli Zaretskii
2014-11-15 11:13 ` martin rudalics
2014-11-15 11:17 ` Eli Zaretskii
2014-11-15 12:12 ` martin rudalics [this message]
2014-11-15 13:05 ` Eli Zaretskii
2014-11-15 13:29 ` martin rudalics
2014-11-15 13:47 ` Eli Zaretskii
2014-11-15 14:32 ` martin rudalics
2014-11-15 17:06 ` Eli Zaretskii
[not found] <emacs-mail-is-unusable-4>
2014-11-15 14:10 ` Angelo Graziosi
2014-11-15 14:33 ` martin rudalics
2014-11-15 17:18 ` Angelo Graziosi
2014-11-16 11:37 ` martin rudalics
2014-11-15 6:57 Kelly Dean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5467433F.4020906@gmx.at \
--to=rudalics@gmx.at \
--cc=19060@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kelly@prtime.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).