* bug#18760: 24.4; Encoding problem in about-emacs
@ 2014-10-18 9:54 Lars Ljung
2014-10-18 11:13 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Lars Ljung @ 2014-10-18 9:54 UTC (permalink / raw)
To: 18760
Hi,
The title of the tutorial is translated in the start-up screen. In the
case of Windows XP with a Swedish locale the title is in UTF-8 but the
buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".
The buffer is using UTF-8 on GNU/Linux so it's not a problem there.
Kind regards,
Lars Ljung
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 9:54 bug#18760: 24.4; Encoding problem in about-emacs Lars Ljung
@ 2014-10-18 11:13 ` Eli Zaretskii
2014-10-18 11:24 ` Lars Ljung
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-18 11:13 UTC (permalink / raw)
To: Lars Ljung; +Cc: 18760
> Date: Sat, 18 Oct 2014 11:54:36 +0200
> From: Lars Ljung <lars@matholka.se>
>
> The title of the tutorial is translated in the start-up screen. In the
> case of Windows XP with a Swedish locale the title is in UTF-8 but the
> buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".
Is that a GUI session or a -nw text-mode session?
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 11:13 ` Eli Zaretskii
@ 2014-10-18 11:24 ` Lars Ljung
2014-10-18 12:24 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Lars Ljung @ 2014-10-18 11:24 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 18760
Den 2014-10-18 13:13, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 11:54:36 +0200
>> From: Lars Ljung <lars@matholka.se>
>>
>> The title of the tutorial is translated in the start-up screen. In the
>> case of Windows XP with a Swedish locale the title is in UTF-8 but the
>> buffer is in iso-8859-1. So "ä" in "användarhandledning" is shown as "ä".
>
> Is that a GUI session or a -nw text-mode session?
>
Only in the GUI. I looked at it a bit and my guess is that the encoding
is not properly detected when extracting the title using
(with-temp-buffer (insert-file-contents ... when defining
fancy-startup-text.
/Lars
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 11:24 ` Lars Ljung
@ 2014-10-18 12:24 ` Eli Zaretskii
2014-10-18 12:36 ` Lars Ljung
2014-10-18 13:02 ` Lars Ljung
0 siblings, 2 replies; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-18 12:24 UTC (permalink / raw)
To: Lars Ljung; +Cc: 18760
> Date: Sat, 18 Oct 2014 13:24:54 +0200
> From: Lars Ljung <lars@matholka.se>
> CC: 18760@debbugs.gnu.org
>
> I looked at it a bit and my guess is that the encoding is not
> properly detected when extracting the title using (with-temp-buffer
> (insert-file-contents ... when defining fancy-startup-text.
But how can this happen, when the tutorial states that it's encoded in
UTF-8?
I just typed that form manually in a locale that also defaults to
Latin-1, and I see no problem at all.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 12:24 ` Eli Zaretskii
@ 2014-10-18 12:36 ` Lars Ljung
2014-10-18 12:57 ` Eli Zaretskii
2014-10-18 13:02 ` Lars Ljung
1 sibling, 1 reply; 12+ messages in thread
From: Lars Ljung @ 2014-10-18 12:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 18760
Den 2014-10-18 14:24, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 13:24:54 +0200
>> From: Lars Ljung <lars@matholka.se>
>> CC: 18760@debbugs.gnu.org
>>
>> I looked at it a bit and my guess is that the encoding is not
>> properly detected when extracting the title using (with-temp-buffer
>> (insert-file-contents ... when defining fancy-startup-text.
>
> But how can this happen, when the tutorial states that it's encoded in
> UTF-8?
>
> I just typed that form manually in a locale that also defaults to
> Latin-1, and I see no problem at all.
>
Perhaps since the encoding is specified at the end of the file but only
the first 256 bytes are read when extracting the title?
/Lars
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 12:36 ` Lars Ljung
@ 2014-10-18 12:57 ` Eli Zaretskii
2014-10-18 13:01 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-18 12:57 UTC (permalink / raw)
To: Lars Ljung; +Cc: 18760
> Date: Sat, 18 Oct 2014 14:36:50 +0200
> From: Lars Ljung <lars@matholka.se>
> CC: 18760@debbugs.gnu.org
>
> Den 2014-10-18 14:24, Eli Zaretskii skrev:
> >> Date: Sat, 18 Oct 2014 13:24:54 +0200
> >> From: Lars Ljung <lars@matholka.se>
> >> CC: 18760@debbugs.gnu.org
> >>
> >> I looked at it a bit and my guess is that the encoding is not
> >> properly detected when extracting the title using (with-temp-buffer
> >> (insert-file-contents ... when defining fancy-startup-text.
> >
> > But how can this happen, when the tutorial states that it's encoded in
> > UTF-8?
> >
> > I just typed that form manually in a locale that also defaults to
> > Latin-1, and I see no problem at all.
> >
>
> Perhaps since the encoding is specified at the end of the file but only
> the first 256 bytes are read when extracting the title?
Where do you see that we only read the first 256 bytes?
Oh, you mean fancy-about-text? I thought you were talking about
fancy-startup-text, where we read the entire file.
Yes, you are right, that's the bug. Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 12:57 ` Eli Zaretskii
@ 2014-10-18 13:01 ` Eli Zaretskii
2014-10-18 17:26 ` Glenn Morris
2014-10-18 19:19 ` Stefan Monnier
0 siblings, 2 replies; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-18 13:01 UTC (permalink / raw)
To: Stefan Monnier, Glenn Morris; +Cc: lars, 18760
> Date: Sat, 18 Oct 2014 15:57:22 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 18760@debbugs.gnu.org
>
> > Perhaps since the encoding is specified at the end of the file but only
> > the first 256 bytes are read when extracting the title?
>
> Where do you see that we only read the first 256 bytes?
>
> Oh, you mean fancy-about-text? I thought you were talking about
> fancy-startup-text, where we read the entire file.
>
> Yes, you are right, that's the bug. Thanks.
So, should we fix this on the emacs-24 branch? Stefan? Glenn?
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 12:24 ` Eli Zaretskii
2014-10-18 12:36 ` Lars Ljung
@ 2014-10-18 13:02 ` Lars Ljung
1 sibling, 0 replies; 12+ messages in thread
From: Lars Ljung @ 2014-10-18 13:02 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 18760
Den 2014-10-18 14:24, Eli Zaretskii skrev:
>> Date: Sat, 18 Oct 2014 13:24:54 +0200
>> From: Lars Ljung <lars@matholka.se>
>> CC: 18760@debbugs.gnu.org
>>
>> I looked at it a bit and my guess is that the encoding is not
>> properly detected when extracting the title using (with-temp-buffer
>> (insert-file-contents ... when defining fancy-startup-text.
>
> But how can this happen, when the tutorial states that it's encoded in
> UTF-8?
>
> I just typed that form manually in a locale that also defaults to
> Latin-1, and I see no problem at all.
>
My mistake. The fault is in fancy-about-text, not fancy-startup-text. I
didn't realise there are two similar texts.
The code for fancy-startup-text used to have the same problem but it was
fixed in revision 109165. The same fix could probably be used in
fancy-about-text.
/Lars
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 13:01 ` Eli Zaretskii
@ 2014-10-18 17:26 ` Glenn Morris
2014-10-18 17:37 ` Eli Zaretskii
2014-10-18 19:19 ` Stefan Monnier
1 sibling, 1 reply; 12+ messages in thread
From: Glenn Morris @ 2014-10-18 17:26 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: lars, 18760
Eli Zaretskii wrote:
> So, should we fix this on the emacs-24 branch? Stefan? Glenn?
Is this new in Emacs 24.4? (I guess not?)
Is it a major problem? (I guess not?)
So, my initial feeling is no.
(I'm going to be out of contact for the next ~ 24 hours, so I defer to
whatever the rest of you decide.)
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 17:26 ` Glenn Morris
@ 2014-10-18 17:37 ` Eli Zaretskii
0 siblings, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-18 17:37 UTC (permalink / raw)
To: Glenn Morris; +Cc: lars, 18760
> From: Glenn Morris <rgm@gnu.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, lars@matholka.se, 18760@debbugs.gnu.org
> Date: Sat, 18 Oct 2014 13:26:50 -0400
>
> Eli Zaretskii wrote:
>
> > So, should we fix this on the emacs-24 branch? Stefan? Glenn?
>
> Is this new in Emacs 24.4? (I guess not?)
No, 24.3 also has it.
> Is it a major problem? (I guess not?)
More like a minor annoyance (and no one complained before, so probably
not many people even try "Help->About Emacs".
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 13:01 ` Eli Zaretskii
2014-10-18 17:26 ` Glenn Morris
@ 2014-10-18 19:19 ` Stefan Monnier
2014-10-23 16:34 ` Eli Zaretskii
1 sibling, 1 reply; 12+ messages in thread
From: Stefan Monnier @ 2014-10-18 19:19 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: lars, 18760
> So, should we fix this on the emacs-24 branch?
Yes, but after 24.4 is released.
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#18760: 24.4; Encoding problem in about-emacs
2014-10-18 19:19 ` Stefan Monnier
@ 2014-10-23 16:34 ` Eli Zaretskii
0 siblings, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-23 16:34 UTC (permalink / raw)
To: Stefan Monnier; +Cc: lars, 18760-done
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Glenn Morris <rgm@gnu.org>, lars@matholka.se, 18760@debbugs.gnu.org
> Date: Sat, 18 Oct 2014 15:19:49 -0400
>
> > So, should we fix this on the emacs-24 branch?
>
> Yes, but after 24.4 is released.
Done.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-10-23 16:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-18 9:54 bug#18760: 24.4; Encoding problem in about-emacs Lars Ljung
2014-10-18 11:13 ` Eli Zaretskii
2014-10-18 11:24 ` Lars Ljung
2014-10-18 12:24 ` Eli Zaretskii
2014-10-18 12:36 ` Lars Ljung
2014-10-18 12:57 ` Eli Zaretskii
2014-10-18 13:01 ` Eli Zaretskii
2014-10-18 17:26 ` Glenn Morris
2014-10-18 17:37 ` Eli Zaretskii
2014-10-18 19:19 ` Stefan Monnier
2014-10-23 16:34 ` Eli Zaretskii
2014-10-18 13:02 ` Lars Ljung
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).