From: Thomas Koch <thomas@koch.ro>
To: "Michael Albinus" <michael.albinus@gmx.de>,
"João Távora" <joaotavora@gmail.com>
Cc: 61350@debbugs.gnu.org
Subject: bug#61350: Eglot over Tramp freezes with large project
Date: Sun, 5 Mar 2023 13:45:49 +0200 (EET) [thread overview]
Message-ID: <54377687.213790.1678016749459@office.mailbox.org> (raw)
In-Reply-To: <877cvvfnp6.fsf@gmx.de>
Thanks Michael for digging! This is exactly what I also think happens.
However my conclusion is different. I consider the root-cause to be the use of JUST-THIS-ONE in tramps call to accept-process-output. Please check my comment to bug
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=12145
Applying a workaround (adding extra code to surpress ControlMaster with a newly introduced hook) would increase the complexity and thus brittleness. I believe the right thing to do is remove JUST-THIS-ONE in Tramp and fix find-name-dired and any other place that's broken.
As a practical roadmap you could add an option to Tramp to disable JUST-THIS-ONE and recommend its use. Later the options default could be toggled. Eventually the option can go away.
Eglot could emit a warning if it sees the above tramp option not being used. (... could lead to Emacs hanging. Are you sure to continue (y/n)?)
> Michael Albinus <michael.albinus@gmx.de> hat am 05.03.2023 13:21 EET geschrieben:
>
>
> João Távora <joaotavora@gmail.com> writes:
>
> Hi João,
>
> >> Yes. But Tramp calls accept-process-output only, if it has send a
> >> command to the remote shell, and it expects something to be returned. At
> >> least the shell prompt.
> >
> > Yes. Tramp is doing the right thing. It really expects a response to
> > come. And more often than not, it does. But sometimes it doesn't, and
> > that's when we hang.
>
> After digging further, I believe I understand now why it hangs. We have
> the following scenario:
>
> - Both Eglot and Tramp use the same ssh connection with enabled ControlMaster.
>
> - Eglot gets JSON output from the remote LSP server. In
> jsonrpc--process-filter, this output is handled. It includes a call to
> file-truename, which triggers Tramp to send a request in its own
> process to the remote side.
>
> - The remote side returns the answer for Tramp (shell output). However,
> the ssh socket is still full of the jsonrpc process output, which
> waits to be handled.
>
> - So the socket is blocked. The jsonrpc output cannot be read, because
> jsonrpc--process-filter waits for the result of file-truename. And the
> Tramp process output cannot be handled, because it is stuck in the
> socket after the jsonrpc output.
>
> The proper solution is indeed to have two connections, and to refuse use
> of ControlMaster.
>
> Surprisingly, this is not new to Tramp :-) But I've simply forgotten the
> case ...
>
> See tramp-integration.el. There is a comment for bug#45518, a similar
> blocking in compile.el. And the solution is indeed to disable ssh
> ControlMaster. Tramp hooks into compilation-mode-hook, and sets
> tramp-use-ssh-controlmaster-options buffer-local to nil.
>
> I'd like to apply the same solution for eglot.el. Unfortunately, there's
> no hook Tramp could use. I've played with eglot-server-initialized-hook,
> but this is applied too late.
>
> So would you mind to add a hook to Eglot, which runs before calling
> make-process, but in the proper process buffer? When you've added it,
> I'll let Tramp hook into, and you don't need any longer the Tramp
> specific code in eglot.el.
>
> In parallel, I'll extend tramp-use-ssh-controlmaster-options to accept a
> further value 'suppress', which overrides possible settings in ~/.ssh/config.
>
> > João
>
> Best regards, Michael.
next prev parent reply other threads:[~2023-03-05 11:45 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 16:33 bug#61350: Eglot over Tramp freezes with large project Thomas Koch
2023-02-17 9:54 ` Michael Albinus
2023-02-17 10:33 ` Thomas Koch
2023-02-18 11:10 ` Thomas Koch
2023-02-18 12:07 ` Michael Albinus
2023-02-23 11:55 ` Thomas Koch
2023-02-25 14:36 ` Michael Albinus
2023-02-23 12:17 ` João Távora
2023-02-23 14:18 ` João Távora
2023-02-23 14:47 ` Thomas Koch
2023-02-23 15:22 ` João Távora
2023-02-24 17:19 ` Michael Albinus
2023-02-24 17:45 ` João Távora
2023-02-25 14:27 ` Michael Albinus
2023-02-25 23:09 ` João Távora
2023-02-26 10:24 ` Thomas Koch
2023-02-26 15:58 ` Michael Albinus
2023-02-26 17:23 ` Michael Albinus
2023-02-26 21:13 ` João Távora
2023-02-26 21:45 ` João Távora
2023-02-27 7:53 ` Michael Albinus
2023-02-27 9:42 ` João Távora
2023-02-27 20:11 ` Michael Albinus
2023-02-27 7:47 ` Michael Albinus
2023-02-27 9:35 ` João Távora
2023-02-27 20:10 ` Michael Albinus
2023-02-28 0:10 ` João Távora
2023-02-28 10:38 ` Michael Albinus
2023-02-28 11:33 ` João Távora
2023-02-28 12:59 ` Michael Albinus
2023-02-28 14:41 ` João Távora
2023-02-28 14:18 ` Michael Albinus
2023-02-28 14:51 ` João Távora
2023-02-28 15:01 ` Michael Albinus
2023-02-28 17:55 ` Thomas Koch
2023-03-01 14:10 ` João Távora
2023-03-01 16:19 ` João Távora
2023-03-02 11:01 ` Michael Albinus
2023-03-02 11:22 ` João Távora
2023-03-02 11:50 ` Michael Albinus
2023-03-05 11:21 ` Michael Albinus
2023-03-05 11:45 ` Thomas Koch [this message]
2023-03-05 12:23 ` Michael Albinus
2023-03-07 12:49 ` Michael Albinus
2023-03-07 13:04 ` Thomas Koch
2023-03-07 13:33 ` João Távora
2023-03-07 13:52 ` Michael Albinus
2023-03-07 14:03 ` João Távora
2023-03-07 14:31 ` Michael Albinus
2023-03-11 9:00 ` Michael Albinus
2023-03-11 10:14 ` Thomas Koch
2023-03-11 11:47 ` João Távora
2023-03-11 12:27 ` Michael Albinus
2023-03-11 11:42 ` João Távora
2023-03-11 12:44 ` Michael Albinus
2023-03-11 14:01 ` João Távora
2023-03-11 14:25 ` Michael Albinus
2023-03-12 0:48 ` João Távora
2023-03-12 10:22 ` Michael Albinus
2023-03-14 11:01 ` Michael Albinus
2023-03-14 15:00 ` Michael Albinus
2023-03-14 15:19 ` João Távora
2023-03-14 15:42 ` Michael Albinus
2023-03-15 17:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 18:05 ` João Távora
2023-03-15 18:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 19:44 ` João Távora
2023-03-15 20:14 ` João Távora
2023-03-15 21:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 21:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 13:28 ` João Távora
2023-03-18 12:34 ` Michael Albinus
2023-03-15 21:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 21:49 ` João Távora
2023-03-16 6:24 ` Jim Porter
2023-03-16 13:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 13:28 ` João Távora
2023-03-16 15:58 ` João Távora
2023-03-16 20:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 22:04 ` João Távora
2023-03-07 13:47 ` Michael Albinus
2023-03-06 12:42 ` Michael Albinus
2023-03-06 13:45 ` João Távora
2023-03-06 13:42 ` João Távora
2023-03-02 10:40 ` Michael Albinus
2023-02-28 19:37 ` João Távora
2023-03-01 8:44 ` Michael Albinus
2023-03-01 11:15 ` João Távora
2023-03-01 10:46 ` Gregory Heytings
2023-03-01 11:08 ` João Távora
2023-03-01 11:23 ` Gregory Heytings
2023-03-01 11:37 ` João Távora
2023-03-01 14:51 ` Michael Albinus
2023-03-01 15:02 ` Gregory Heytings
2023-04-24 1:44 ` Aaron Madlon-Kay
2023-05-05 11:32 ` Michael Albinus
2023-05-05 13:14 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 14:53 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54377687.213790.1678016749459@office.mailbox.org \
--to=thomas@koch.ro \
--cc=61350@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).