From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18649: 25.0.50; Closing TTY menus on MS-Windows Date: Wed, 08 Oct 2014 15:35:31 +0200 Message-ID: <54353DA3.8020202@gmx.at> References: <83oatnlw6i.fsf@gnu.org> <543504AF.9050300@gmx.at> <83lhoqkg67.fsf@gnu.org> <83fveyk9pa.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1412775392 17661 80.91.229.3 (8 Oct 2014 13:36:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Oct 2014 13:36:32 +0000 (UTC) Cc: 18649-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 08 15:36:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XbrPj-0008DG-98 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Oct 2014 15:36:23 +0200 Original-Received: from localhost ([::1]:36295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbrPi-0004zl-Kf for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Oct 2014 09:36:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbrPW-0004or-AH for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:36:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbrPO-0000o7-5L for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:36:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbrPO-0000o3-2p for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XbrPN-0007Xp-Qy for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Oct 2014 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18649-done@debbugs.gnu.org id=D18649.141277534628980 (code D ref 18649); Wed, 08 Oct 2014 13:36:01 +0000 Original-Received: (at 18649-done) by debbugs.gnu.org; 8 Oct 2014 13:35:46 +0000 Original-Received: from localhost ([127.0.0.1]:37563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbrP8-0007XM-Af for submit@debbugs.gnu.org; Wed, 08 Oct 2014 09:35:46 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:64643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbrP4-0007XC-AT for 18649-done@debbugs.gnu.org; Wed, 08 Oct 2014 09:35:43 -0400 Original-Received: from [91.113.3.198] ([91.113.3.198]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LhSfM-1XxwbY3jw8-00mbys; Wed, 08 Oct 2014 15:35:37 +0200 In-Reply-To: <83fveyk9pa.fsf@gnu.org> X-Provags-ID: V03:K0:ffp4CKDIQNrwVvGpw2PPFJq5oz9x+4giqZqhj5TyCD6/dxK2abU aHAoN0PIMGjJKMI4/o8cDvaBW7zVHy2AO+HwEBbgtuu6RGAjatULo5W9MZ5r2P+XYFcrGsA zL0Y5HShsp7Rl4lwkORfPEsIRiAO9IBRhJrcRQEA+VuSzXcE+7KcQBL3Tf4Wkmcp5FYVMCG Ha1XHTvH1qJwEAQWjWEVA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94295 >> BTW: Is there a way to turn `blink-cursor-mode' off on a TTY? > > No, it blinks "in hardware" (i.e., the terminal software does it). > And there's no reason to disable it, because it should never do > anything on a TTY. Or do you have evidence to the contrary? No. I just wondered why the cursor disappeared (as Dani also observed) when doing C-g with an open menu. > It wasn't an old bug, it was indeed caused by the pixel-wise changes. > Specifically, the fact that as part of the call to change_frame_size, > we can now call Lisp (in frame_windows_min_size). But this is not new, change_frame_size called resize_frame_windows, which called Lisp before. > The other part of > the puzzle is that w32_console_read_socket calls change_frame_size > unconditionally on every event it reads, because Windows doesn't tell > us about resizes of the console window. > > So what happened was that we read the C-g key, called > kbd_buffer_store_event for it, which set Vquit_flag, and then we > called change_frame_size, which did QUIT when frame_windows_min_size > called Lisp. Ah, I seem to understand. resize_frame_windows never gets called here because the size of the root window apparently doesn't change. OTOH frame_windows_min_size gets called unconditionally. So it's merely coincidental that this problem didn't hit us before. BTW, I call frame_windows_min_size unconditionally in order to detect the case where (1) the frame size itself should be conceptually left unchanged, but (2) something _within_ the frame changes (like adding a tool or scroll bar) which requires a larger frame size to keep all windows of the frame visible. All this is unnecessary on TTYs. > I fixed that by passing a non-zero DELAY argument to > change_frame_size, so that it delays the actual resize to the next > opportunity, like the next redisplay cycle. Works here. > I'm closing this bug. Many thanks, martin