From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Sun, 28 Sep 2014 21:04:00 +0200 Message-ID: <54285BA0.6080205@gmx.at> References: <290964377.56621411668876487.JavaMail.www@wwinf7125> <83a95nv9fm.fsf@gnu.org> <542668BA.6010800@gmx.at> <838ul5tpfu.fsf@gnu.org> <54268B0B.1020203@gmx.at> <8361g9tijj.fsf@gnu.org> <5426BD71.4000705@gmx.at> <83zjdlrqti.fsf@gnu.org> <5427099F.6080406@gmx.at> <83tx3ssw5x.fsf@gnu.org> <5427D5F0.9050303@gmx.at> <83r3yvn1r3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1411931133 12401 80.91.229.3 (28 Sep 2014 19:05:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Sep 2014 19:05:33 +0000 (UTC) Cc: lompik@voila.fr, 18545@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 28 21:05:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYJme-00049k-Vi for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Sep 2014 21:05:25 +0200 Original-Received: from localhost ([::1]:60840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYJme-00051Y-Eq for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Sep 2014 15:05:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYJmV-0004zZ-3B for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 15:05:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYJmN-0002Cy-LB for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 15:05:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYJmN-00021j-I8 for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 15:05:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYJmI-0003CJ-0m for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 15:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Sep 2014 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141193105312230 (code B ref 18545); Sun, 28 Sep 2014 19:05:01 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 28 Sep 2014 19:04:13 +0000 Original-Received: from localhost ([127.0.0.1]:54571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYJlU-0003BC-G6 for submit@debbugs.gnu.org; Sun, 28 Sep 2014 15:04:12 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:61759) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYJlS-0003B4-8T for 18545@debbugs.gnu.org; Sun, 28 Sep 2014 15:04:11 -0400 Original-Received: from [62.46.208.76] ([62.46.208.76]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lkwc9-1Y91xX0jif-00anfA; Sun, 28 Sep 2014 21:04:02 +0200 In-Reply-To: <83r3yvn1r3.fsf@gnu.org> X-Provags-ID: V03:K0:NKKF2C/AW0A/gG+V+1ZG87jmpm7b3T6F35nA4BIiuMahv4IM0W8 6iLejzV5poznzIxByIvTIHm4kOQXA6crrnUA5FlEACGjrgtsELLWNBEFgSKngwOEaKW8MaY OXUXRahwUsFpQwtSg7M1uLqpL4kbaQeBytUqs/e6UfP3mDiqsVKRT8HzFSaghlU2Je9eKBA L8ilXgCw0RL8eRIsYfkEA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93837 Archived-At: >> >> I don't >> >> understand cursor_row_fully_visible_p much. >> > >> > Which part of it do you not understand? >> >> Why it should return 1 in these two cases >> >> if (!MATRIX_ROW_PARTIALLY_VISIBLE_P (w, row)) >> return 1; > > If a row is _not_ partially visible, it is _fully_ visible, right? Hmmm ... yes. Unless it's completely invisible. I was probably fooled by the inverted uses of fully and partially visible. >> and >> >> if (row->height >= window_height) >> { >> if (!force_p || MINI_WINDOW_P (w) >> || w->vscroll || w->cursor.vpos == 0) >> return 1; >> } > > There's a comment that that's supposed to explain this. I don't understand the || w->vscroll || w->cursor.vpos == 0 disjuncts in the second conditional. But I presume that this case is too obscure anyway. martin