unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#18544: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms
@ 2014-09-24 13:22 Ken Brown
  2014-09-24 13:45 ` Dmitry Antipov
  0 siblings, 1 reply; 3+ messages in thread
From: Ken Brown @ 2014-09-24 13:22 UTC (permalink / raw)
  To: 18544

bzr rev 117935 breaks the build on all platforms other than GNU/Linux. 
The following patch restores the code to what I think was intended:

=== modified file 'src/lisp.h'
--- src/lisp.h  2014-09-24 11:59:13 +0000
+++ src/lisp.h  2014-09-24 12:59:07 +0000
@@ -290,9 +290,9 @@
  #ifndef USE_STACK_LISP_OBJECTS
  # if defined (GNU_LINUX) && defined (__GNUC__) && !defined (__clang__)
  #   define USE_STACK_LISP_OBJECTS true
+# else
+#   define USE_STACK_LISP_OBJECTS false
  # endif
-#else
-# define USE_STACK_LISP_OBJECTS false
  #endif

  #if defined HAVE_STRUCT_ATTRIBUTE_ALIGNED && USE_STACK_LISP_OBJECTS


In GNU Emacs 24.4.50.2 (x86_64-unknown-cygwin)
  of 2014-09-24 on fiona
Repository revision: 117935 
dmantipov@yandex.ru-20140924115913-as413xc2t3d1xq60
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
  `configure --with-w32 --with-file-notification=no
  --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3''

Configured features:
XPM JPEG TIFF GIF PNG IMAGEMAGICK DBUS ACL GNUTLS LIBXML2 ZLIB

Important settings:
   value of $LANG: en_US.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t

Recent input:
M-x r e p o r t - e m <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind w32
multi-tty emacs)

Memory information:
((conses 16 78103 5040)
  (symbols 48 17816 0)
  (miscs 40 43 115)
  (strings 32 12754 3583)
  (string-bytes 1 313824)
  (vectors 16 10021)
  (vector-slots 8 382326 12678)
  (floats 8 70 196)
  (intervals 56 202 12)
  (buffers 976 12))






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#18544: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms
  2014-09-24 13:22 bug#18544: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms Ken Brown
@ 2014-09-24 13:45 ` Dmitry Antipov
  2014-09-24 14:13   ` Ken Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Antipov @ 2014-09-24 13:45 UTC (permalink / raw)
  To: Ken Brown; +Cc: 18544

On 09/24/2014 05:22 PM, Ken Brown wrote:

> bzr rev 117935 breaks the build on all platforms other than GNU/Linux.
> The following patch restores the code to what I think was intended:
>
> === modified file 'src/lisp.h'
> --- src/lisp.h  2014-09-24 11:59:13 +0000
> +++ src/lisp.h  2014-09-24 12:59:07 +0000
> @@ -290,9 +290,9 @@
>   #ifndef USE_STACK_LISP_OBJECTS
>   # if defined (GNU_LINUX) && defined (__GNUC__) && !defined (__clang__)
>   #   define USE_STACK_LISP_OBJECTS true
> +# else
> +#   define USE_STACK_LISP_OBJECTS false
>   # endif
> -#else
> -# define USE_STACK_LISP_OBJECTS false
>   #endif

Oops.  Surely you're right.  Should be fixed in 117936.

Dmitry






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#18544: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms
  2014-09-24 13:45 ` Dmitry Antipov
@ 2014-09-24 14:13   ` Ken Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Ken Brown @ 2014-09-24 14:13 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: 18544-done

On 9/24/2014 9:45 AM, Dmitry Antipov wrote:
> Oops.  Surely you're right.  Should be fixed in 117936.

Confirmed.  Thanks.

Ken





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-24 14:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 13:22 bug#18544: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms Ken Brown
2014-09-24 13:45 ` Dmitry Antipov
2014-09-24 14:13   ` Ken Brown

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).