From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18528@debbugs.gnu.org
Subject: bug#18528: 24.3.93; Crash during restoration of frameset from desktop
Date: Tue, 23 Sep 2014 18:15:49 +0200 [thread overview]
Message-ID: <54219CB5.6080103@gmx.at> (raw)
In-Reply-To: <8361gexsrg.fsf@gnu.org>
>> We have to check these values anyway because our window structure might
>> be too complex to fit into the rectangle returned by GetClientRect.
>
> Sorry, I don't think I understand this. GetClientRect just returns
> the dimensions of our frame, it doesn't know anything about Emacs
> windows.
If all values returned by GetClientRect are zero, it's all to obvious
that our windows won't fit. But if, for example, rect.right - rect.left
is too small to fit our windows, we face a similar same problem and have
to handle that anyway. So I'm not sure whether we should separately
deal with the case where all rectangle values are zero.
>> I never got around to ask you: Do you anywhere see a need to round up
>> the values of new_cols and new_lines in cases like this?
>
> Yes, I think so. I think the reason we didn't see any problems with
> that is that GUI windows always over-allocate their glyph matrices, to
> be prepared for dealing with the smallest possible font, which is
> rarely if ever used. But I think if you actually use that smallest
> font for the default face, you will see the problem.
I thought it's not needed because in required_matrix_width we use the
pixel width when HAVE_WINDOW_SYSTEM is defined.
> (Just make sure you don't round up for TTY frames, so as not to add
> one extra row there.)
martin
next prev parent reply other threads:[~2014-09-23 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:23 bug#18528: 24.3.93; Crash during restoration of frameset from desktop Eli Zaretskii
2014-09-22 17:43 ` martin rudalics
2014-09-22 18:13 ` Eli Zaretskii
2014-09-23 5:48 ` martin rudalics
2014-09-23 15:26 ` Eli Zaretskii
2014-09-23 16:15 ` martin rudalics [this message]
2014-09-23 18:46 ` Eli Zaretskii
2014-09-23 19:17 ` martin rudalics
2014-09-23 19:30 ` Eli Zaretskii
2014-09-23 19:42 ` Eli Zaretskii
2014-09-24 6:16 ` martin rudalics
2014-09-24 7:15 ` Eli Zaretskii
2014-09-24 7:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54219CB5.6080103@gmx.at \
--to=rudalics@gmx.at \
--cc=18528@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).