unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18528@debbugs.gnu.org
Subject: bug#18528: 24.3.93; Crash during restoration of frameset from desktop
Date: Tue, 23 Sep 2014 07:48:40 +0200	[thread overview]
Message-ID: <542109B8.6080107@gmx.at> (raw)
In-Reply-To: <83bnq7y13y.fsf@gnu.org>

 > I certainly think so.  If GetClientRect fails, how does it make sense
 > to use what we find in the rectangle data structure we passed to it?
 > The values there are just garbage.

We have to check these values anyway because our window structure might
be too complex to fit into the rectangle returned by GetClientRect.  But
then we should probably also rewrite things like w32_clear_window as

   if (hdc && GetClientRect (FRAME_W32_WINDOW (f), &rect))
     w32_clear_rect (f, hdc, &rect);

 >>   > +  /* Recompute the dimensions in character units, since
 >>   > +     check_frame_size might have changed the pixel dimensions.  */
 >>   > +  /* Consider rounding here: Currently, the root window can be
 >>   > +     larger than the frame in terms of columns/lines.  */
 >>   > +  new_cols = new_text_width / FRAME_COLUMN_WIDTH (f);
 >>   > +  new_lines = new_text_height / FRAME_LINE_HEIGHT (f);

I never got around to ask you: Do you anywhere see a need to round up
the values of new_cols and new_lines in cases like this?

martin





  reply	other threads:[~2014-09-23  5:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 15:23 bug#18528: 24.3.93; Crash during restoration of frameset from desktop Eli Zaretskii
2014-09-22 17:43 ` martin rudalics
2014-09-22 18:13   ` Eli Zaretskii
2014-09-23  5:48     ` martin rudalics [this message]
2014-09-23 15:26       ` Eli Zaretskii
2014-09-23 16:15         ` martin rudalics
2014-09-23 18:46           ` Eli Zaretskii
2014-09-23 19:17             ` martin rudalics
2014-09-23 19:30               ` Eli Zaretskii
2014-09-23 19:42                 ` Eli Zaretskii
2014-09-24  6:16                   ` martin rudalics
2014-09-24  7:15                     ` Eli Zaretskii
2014-09-24  7:33                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542109B8.6080107@gmx.at \
    --to=rudalics@gmx.at \
    --cc=18528@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).