unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18493@debbugs.gnu.org
Subject: bug#18493: 24.3.93; posn-col-row should take text-scale-mode into account
Date: Fri, 19 Sep 2014 00:55:06 +0400	[thread overview]
Message-ID: <541B46AA.2020904@yandex.ru> (raw)
In-Reply-To: <8338bp2cwf.fsf@gnu.org>

On 09/18/2014 06:58 PM, Eli Zaretskii wrote:

> That's the intended behavior: posn-col-row is documented to return the
> coordinates of its argument in canonical character units.  And that is
> what it does here.  There's no bug here.

Fair enough. Maybe define an alternative function, which does take  text 
zoom into account?

Or otherwise, I'd be fine with precise algorithm how to convert one into 
the other, if it's relatively simple and unlikely to change.

> Calculate what, exactly?  The results of this function _are_ reliable.
> You just cannot in general use them as the logical (a.k.a. "physical")
> column and row number, i.e. the ordinal number of a character from the
> line beginning and its line number relative to window-start.  You can
> only use them as the real column and row if your text uses the default
> face.  But once variable-size fonts, stretch glyphs, images, and other
> display atrocities come into play, there's no meaningful way of
> talking about "columns" and "rows" that can be used as indices into
> the text.

Text zoom is different from all the other features you enumerate here, 
though. In programming language buffers, I usually have no images or 
proportional fonts, but zooming the text is something that happens once 
in a while.

> So the answer to your question depends on what you intend to do with
> the value.

All the recent display engine issues I've been creating are for the same 
package and feature: company-mode and its overlay-based popup, which I'd 
like to polish up a bit before trying other methods of popup rendering, 
because they won't be available to users of Emacs 24.4 and older 
versions, and it'll likely be quite some time until the next release.

> IOW, please explain what is it that "you'd like".

The "current column" obtained from the return value of this function, is 
used to position each line of the popup in the display string of the 
overlay that spans the next few lines. So naturally, the return value 
should not depend on the zoom level. And I'm using `posn-col-row' for 
this because it became the consensus in the several discussions I've had 
with you recently on this subject.





  reply	other threads:[~2014-09-18 20:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 22:03 bug#18493: 24.3.93; posn-col-row should take text-scale-mode into account Dmitry
2014-09-17 22:53 ` Drew Adams
2014-09-17 23:17   ` Dmitry Gutov
2014-09-18  1:56     ` Drew Adams
2014-09-18  9:46       ` Dmitry Gutov
2014-09-18 15:37         ` Drew Adams
2014-09-18 16:50           ` Eli Zaretskii
2014-09-18 14:59       ` Eli Zaretskii
2014-09-18  9:32 ` martin rudalics
2014-09-18  9:35   ` Dmitry Gutov
2014-09-18 14:58 ` Eli Zaretskii
2014-09-18 20:55   ` Dmitry Gutov [this message]
2014-09-19  1:05     ` Stefan Monnier
2014-09-19  1:07       ` Dmitry Gutov
2014-09-19  6:11     ` Eli Zaretskii
2014-09-19 11:17       ` Dmitry Gutov
2014-09-19 13:22         ` Eli Zaretskii
2014-09-19 18:08           ` Dmitry Gutov
2014-09-19 19:46             ` Eli Zaretskii
2014-09-22  3:59               ` Dmitry Gutov
2014-09-19 14:54         ` Stefan Monnier
2014-09-19 15:43           ` Eli Zaretskii
2014-09-19 17:38             ` Dmitry Gutov
2014-09-20  1:17               ` Stefan Monnier
2014-09-22  3:59                 ` Dmitry Gutov
     [not found] <<864mw529bx.fsf@yandex.ru>
     [not found] ` <<38e6b538-3e76-472a-b371-2e74f9a14bf7@default>
     [not found]   ` <<541A1693.4090009@yandex.ru>
     [not found]     ` <<30fb9ae4-3781-4bc7-a1cf-45bf2a195929@default>
     [not found]       ` <<831tr92cuq.fsf@gnu.org>
2014-09-18 15:37         ` Drew Adams
2014-09-18 16:39           ` Eli Zaretskii
2014-09-19  1:00           ` Stefan Monnier
     [not found]         ` <<ebad225f-4bc4-426c-a135-8d1d15551fda@default>
     [not found]           ` <<83sijo2893.fsf@gnu.org>
2014-09-18 17:12             ` Drew Adams
2014-09-18 17:22               ` Eli Zaretskii
     [not found] ` <<8338bp2cwf.fsf@gnu.org>
2014-09-18 15:52   ` Drew Adams
2014-09-18 17:00     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541B46AA.2020904@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=18493@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).