unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18357@debbugs.gnu.org, stephen.berman@gmx.net
Subject: bug#18357: 24.3.93; Calendar not fully displayed
Date: Sat, 30 Aug 2014 19:15:54 +0200	[thread overview]
Message-ID: <540206CA.40204@gmx.at> (raw)
In-Reply-To: <83k35qgc2d.fsf@gnu.org>

 >> The mode line face specifies the height of the mode line.  IIUC
 >> `fit-window-to-buffer' gets this height via CURRENT_MODE_LINE_HEIGHT (in
 >> dispextern.h) which is likely wrong if the font has not been applied yet
 >> to the target window.
 >
 > Yes, but the original recipe involved Customize to change the
 > mode-line face, so in that case the changes in the mode-line face have
 > propagated long ago by the time "M-x calendar" is invoked.

They propagated to the selected window only.  The calendar window does
not even exist at that time.

 > So I don't see how the above explanation could be relevant to the
 > original issue.

I have no other one.  The scenarios differ in one point: In mine the
mode lines of all windows are the same height, but
`fit-window-to-buffer' doesn't know that height yet when it's executed.

For Stephen's the estimate is for a non-selected window and `calendar'
selects the window _after_ `fit-window-to-buffer' was executed.

If you have a better explanation, I'll be all ears.

 >> Note that we allow the font to change the height of the mode line which
 >> may partially overwrite the last line(s) of the window text.  This seems
 >> to backfire here
 >
 > I see no "backfire".  Emacs scrolls the window to make point fully
 > visible, that's all.

It backfires because `fit-window-to-buffer' can't make the window tall
enough since it doesn't yet know how large the mode line will be.  And
since it never will be clairvoyant enough to know which window will be
selected, I see no chance to reliably fix Stephen's scenario.

martin





  reply	other threads:[~2014-08-30 17:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 18:24 bug#18357: 24.3.93; Calendar not fully displayed Stephen Berman
2014-08-29 19:07 ` Stephen Berman
2014-08-30  9:58 ` Eli Zaretskii
2014-08-30 11:32   ` Stephen Berman
2014-08-30 12:34     ` Eli Zaretskii
2014-08-30 14:07       ` Stephen Berman
2014-08-30 16:40         ` martin rudalics
2014-08-30 12:43     ` martin rudalics
2014-08-30 12:48       ` martin rudalics
2014-08-30 13:27         ` Eli Zaretskii
2014-08-30 13:51           ` martin rudalics
2014-08-30 14:09             ` Eli Zaretskii
2014-08-30 16:40               ` martin rudalics
2014-08-30 16:46                 ` Eli Zaretskii
2014-08-30 17:15                   ` martin rudalics [this message]
2014-08-30 17:54                     ` Eli Zaretskii
2014-08-30 18:08                       ` martin rudalics
2014-08-30 19:35                         ` Stephen Berman
2014-08-31 11:28                           ` martin rudalics
2014-09-01  9:18                             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540206CA.40204@gmx.at \
    --to=rudalics@gmx.at \
    --cc=18357@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).