From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#18360: Modularize recent qsort_r additions Date: Sat, 30 Aug 2014 09:39:32 -0700 Organization: UCLA Computer Science Department Message-ID: <5401FE44.4050800@cs.ucla.edu> References: <5400E959.3000805@cs.ucla.edu> <831tryigev.fsf@gnu.org> <5401D54B.40601@cs.ucla.edu> <83ppfigj2a.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409416833 12652 80.91.229.3 (30 Aug 2014 16:40:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Aug 2014 16:40:33 +0000 (UTC) Cc: 18360@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 30 18:40:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNlhO-0004m6-4B for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 18:40:22 +0200 Original-Received: from localhost ([::1]:47137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNlhN-0007Zh-LB for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 12:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNlhD-0007XS-IT for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 12:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNlh5-0001wj-0t for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 12:40:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNlh4-0001wQ-TY for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 12:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNlh4-0007CZ-EU for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Aug 2014 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18360-submit@debbugs.gnu.org id=B18360.140941679227663 (code B ref 18360); Sat, 30 Aug 2014 16:40:02 +0000 Original-Received: (at 18360) by debbugs.gnu.org; 30 Aug 2014 16:39:52 +0000 Original-Received: from localhost ([127.0.0.1]:54550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNlgt-0007C7-UO for submit@debbugs.gnu.org; Sat, 30 Aug 2014 12:39:52 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:44005) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNlgq-0007Bs-AZ for 18360@debbugs.gnu.org; Sat, 30 Aug 2014 12:39:49 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 36CD0A60013; Sat, 30 Aug 2014 09:39:42 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vp6z4WpW3JcR; Sat, 30 Aug 2014 09:39:33 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5ED2FA60002; Sat, 30 Aug 2014 09:39:33 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 In-Reply-To: <83ppfigj2a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92865 Archived-At: Eli Zaretskii wrote: > That is a different issue, and should not get in our way here. For > the purposes of this bug, can we agree that qsort_r is not needed, and > the changes that use it should be reverted to use qsort instead? Yes and no. The previous version did not use qsort, so reverting the changes that use qsort_r will the drop the use of qsort (and qsort_r) entirely. One could further *modify* the changes to stop using qsort_r, and to use qsort only. But what would be the point? qsort (and qsort_r) are mistakes here; we cannot use them. Dropping the use of qsort_r would be like wiping the lipstick off a pig.