From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.bugs Subject: bug#18361: New 'sort' implementation can crash Emacs Date: Sat, 30 Aug 2014 10:55:17 +0400 Message-ID: <54017555.8010903@yandex.ru> References: <5400EFA5.6090902@cs.ucla.edu> <540102E5.6040404@yandex.ru> <5401079D.7070505@cs.ucla.edu> <54015C22.5030108@yandex.ru> <54015FA8.5070400@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1409381785 11172 80.91.229.3 (30 Aug 2014 06:56:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Aug 2014 06:56:25 +0000 (UTC) Cc: 18361@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 30 08:56:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNcaB-0004Ot-6J for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 08:56:19 +0200 Original-Received: from localhost ([::1]:45430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNcaA-0003Yj-Mo for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 02:56:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNca1-0003Wp-SV for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 02:56:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNcZv-0001hP-Ql for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 02:56:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNcZv-0001hA-KR for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 02:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNcZu-0006t8-Os for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 02:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Antipov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Aug 2014 06:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18361-submit@debbugs.gnu.org id=B18361.140938173226434 (code B ref 18361); Sat, 30 Aug 2014 06:56:02 +0000 Original-Received: (at 18361) by debbugs.gnu.org; 30 Aug 2014 06:55:32 +0000 Original-Received: from localhost ([127.0.0.1]:53953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNcZP-0006sH-Et for submit@debbugs.gnu.org; Sat, 30 Aug 2014 02:55:31 -0400 Original-Received: from forward5m.cmail.yandex.net ([5.255.216.23]:56347) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNcZL-0006s0-Qc for 18361@debbugs.gnu.org; Sat, 30 Aug 2014 02:55:29 -0400 Original-Received: from smtp9.mail.yandex.net (smtp9.mail.yandex.net [77.88.61.35]) by forward5m.cmail.yandex.net (Yandex) with ESMTP id 70A77804F3; Sat, 30 Aug 2014 10:55:18 +0400 (MSK) Original-Received: from smtp9.mail.yandex.net (localhost [127.0.0.1]) by smtp9.mail.yandex.net (Yandex) with ESMTP id CE97A15200F7; Sat, 30 Aug 2014 10:55:17 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp9.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id ohKxovX1OQ-tHsCV9ag; Sat, 30 Aug 2014 10:55:17 +0400 (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: 9400e389-b04c-46be-9bb5-7f1bc6ca76bd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1409381717; bh=Z7w34BsjuhjF7Qzo+E8JmyA4Vv5oj/nX05PVksJFxQA=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=kHdYYZculv5hwflU9e370GtOkXvIl81We+lATjvSTDW1kNuYaAw5GsUMJiwI1Xi9t zrOrejgEBYlIwz74eWKiESbSG48bfrrUDUH363XbNKXCsMzP/r7LwUE23B4kyZ7hJe mBYTgsMAfPFpGYyY9RiPGcz85sAvelWgNQY4s0+I= Authentication-Results: smtp9.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 In-Reply-To: <54015FA8.5070400@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92842 Archived-At: On 08/30/2014 09:22 AM, Paul Eggert wrote: > See, for example, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42157 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51297 Very nice. But couldn't we detect an improper comparison function at runtime? For example: === modified file 'src/fns.c' --- src/fns.c 2014-08-29 19:18:06 +0000 +++ src/fns.c 2014-08-30 06:52:20 +0000 @@ -1933,6 +1933,8 @@ preserve original order. Pretty ugly but works. */ more = NILP (call2 (sort_vector_predicate, vp, vq)); less = NILP (call2 (sort_vector_predicate, vq, vp)); + if (!more && !less) + error ("Not an anti-symmetrical predicate in sort"); return ((more && !less) ? 1 : ((!more && less) ? -1 : XSAVE_INTEGER (op, 0) - XSAVE_INTEGER (oq, 0))); Dmitry