From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Date: Mon, 18 Sep 2023 12:12:41 -0300 Message-ID: <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 66071@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 17:13:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiFvt-000ALx-HT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 17:13:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiFvl-0007qX-Qo; Mon, 18 Sep 2023 11:12:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFvi-0007pt-GC for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:12:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiFvi-0000z8-8V for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:12:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiFvq-0008LD-GB for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66071-submit@debbugs.gnu.org id=B66071.169504998132055 (code B ref 66071); Mon, 18 Sep 2023 15:13:02 +0000 Original-Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:13:01 +0000 Original-Received: from localhost ([127.0.0.1]:54057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiFvo-0008Kw-U0 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:13:01 -0400 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:49562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiFvm-0008KX-Bm for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:13:00 -0400 Original-Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3adcec86a8cso854417b6e.3 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695049964; x=1695654764; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k6qxSgf1geUkY3RIbwQIw7YAWlvbdAO4kD5LING4QOY=; b=fh/RL1ih6f0yU6GRQRYjy2u0LgP4mGYe+kPepgMaLXdezZ7zoCZ+lGZLpxteYFVCj/ JiFhQTRD5sc9CrT5otsP575xMtVJ4B+KE6M3GsKwgFyn7poteeQVsiKTSXfKnrCTEGpT f303MBnoUM9tQOwEvrqCdBEy88bzRos83VnCjKiLO++lgzWSLSvQJLmod5DLaYUPYcJT BIaqrSGyBRJJVYKXzE2ptcQT/H2ucCyrxAtUKQkTACSPja6WAsfgldbSlMVX9nUsu1IY 9GkA03xAddiJR35lfyR/OeDsQnhPsozNsOloOg/YpWxFg2gayagfSWZ47jwWU1L6WoMc Xk9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695049964; x=1695654764; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k6qxSgf1geUkY3RIbwQIw7YAWlvbdAO4kD5LING4QOY=; b=FbdoHU0pdicall05lKay1xnS7Ul1RvjQT9D6yc4SJyfYPovwrZpxPEtTxlJo53lYbv HRnKhZbKEBn/g7WmpeBp/fRzLgIMcmOjd5NgKFreHNOAUUr2RAj0W4F32fc0LN7gWX5o XCZI4VQQvLCSKsTkSTOa2V1/jnrpK3PHEfxlxnYSNJAu/4pF4mMGgxqfD489JW34fPLR ROL+n5vPOBbJ3C9S+EZwtO+pkTGzW8Ql+NvX2HnIyzi2H+aOToZmryvOa1qi0JBhWdva QKOiIlMG/pGQG0in3KunRPbXcll4qN9riBOgXf843sYrbrqK5oW4SSC3p94IJFrILHGz whvg== X-Gm-Message-State: AOJu0YzjI+lPCsnT2ACVmnA1z67F+JTqvEHf0QEPk7YAzdkg1UfqGYDt t5N2/NUG0P/PdvXHAEcCzGk= X-Google-Smtp-Source: AGHT+IGw4Ib+YBr/SHs+Hp8b6G3nJn8HIbX7gJePAdsHZF0xvCwNTa/9qt6fYD5jQjOCA/KTdFW0JA== X-Received: by 2002:a05:6808:1b2c:b0:3a4:6a:6363 with SMTP id bx44-20020a0568081b2c00b003a4006a6363mr12616704oib.14.1695049964168; Mon, 18 Sep 2023 08:12:44 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id l23-20020a056808021700b003adbd352e28sm2235692oie.58.2023.09.18.08.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 08:12:43 -0700 (PDT) Content-Language: en-US In-Reply-To: <871qevk1fh.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270809 Archived-At: On 18/9/23 11:20, Robert Pluim wrote: > On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda said: >     Mauro> Patch attached. > >     Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 00:00:00 2001 >     Mauro> From: Mauro Aranda >     Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >     Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type (Bug#66071) > >     Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add missing choices. >     Mauro> --- >     Mauro>  lisp/term.el | 5 ++++- >     Mauro>  1 file changed, 4 insertions(+), 1 deletion(-) > >     Mauro> diff --git a/lisp/term.el b/lisp/term.el >     Mauro> index b8466b21332..5dd73447cfb 100644 >     Mauro> --- a/lisp/term.el >     Mauro> +++ b/lisp/term.el >     Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output > >     Mauro>  See variable `term-scroll-show-maximum-output'. >     Mauro>  This variable is buffer-local." >     Mauro> -  :type 'boolean >     Mauro> +  :type '(choice (const :tag "Don't scroll" nil) >     Mauro> +                 (const :tag "Scroll selected window only" this) >     Mauro> +                 (const :tag "Scroll unselected windows" others) >     Mauro> +                 (other :tag "Scroll all windows" t)) >     Mauro>    :group 'term) > > The code (and the docstring) also mention 'all. I know, that's why I put other, to catch either t or 'all, since it doesn't make sense to have 2 different items for the same option. And adding something to match only t or 'all didn't seem worth the trouble. Am I missing something?