From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Date: Mon, 10 Oct 2022 10:49:05 -0700 Message-ID: <53e0022a-ed95-cfad-fa09-a0d6bacdf86b@gmail.com> References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> <83tu4cgivn.fsf@gnu.org> <834jwbhawi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------UJ3uT9uQ4viKdlQzs6aUlZ0a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58404@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 20:58:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohxyV-000828-8S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 20:58:03 +0200 Original-Received: from localhost ([::1]:50708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohxyU-0005G9-8o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 14:58:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwuj-0000w4-Qs for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 13:50:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohwug-0002gU-Gh for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 13:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohwug-0001cu-5Y for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58404-submit@debbugs.gnu.org id=B58404.16654241546190 (code B ref 58404); Mon, 10 Oct 2022 17:50:02 +0000 Original-Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 17:49:14 +0000 Original-Received: from localhost ([127.0.0.1]:49829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohwtu-0001bm-DX for submit@debbugs.gnu.org; Mon, 10 Oct 2022 13:49:14 -0400 Original-Received: from mail-pf1-f179.google.com ([209.85.210.179]:43853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohwtr-0001bW-PQ for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 13:49:12 -0400 Original-Received: by mail-pf1-f179.google.com with SMTP id 204so11349320pfx.10 for <58404@debbugs.gnu.org>; Mon, 10 Oct 2022 10:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XPIqlRwlhP6HMyJh+aZ4+d6470cktzsD6/uhoGJUeuE=; b=A41sW3X2rjQPHGQiXTk0Eq54dIsxeOQZvY0xQRt39qYhSe6E1cmLQ4PLLAgprmCq4q gbhCSvkMBxWe+JwdUxz97CuWBadtzCF1eK4Z0LdKsINmI0ZckKBq4bg8+a3dmsy+0tdS 13T5i2cLVe1fkmh9KTECzTLgZe9liyPJVq6k1BAOlEjkAnAzyuF99+LiWMGjmK6epZ9n jEq2UKJXqywRxBrYFkDtHCCYxPYQSjeadYjQZcDcd9ZmTL6VIj+h+P6Qznd6/N/IfSM5 CRtxnFozKqCq8O8itNpd2AyiooiGSu4X4iteMf6LFBgF40g16t/hP4Ln8E8uk/kbtkup OS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XPIqlRwlhP6HMyJh+aZ4+d6470cktzsD6/uhoGJUeuE=; b=r7dnstwJAbEJz7rPCGTz6o2Hh+zA6XLw/Sjo/IkcGPwp9Mb0pJ1Sw+omTTgn12qB/+ 69EjmIwoXc0WxF+0nQaAYSOCql6iPlrLaxhFW8QliCNa1+lhVczb/zwdY6a89UrkQMZn rSdepcvYpPq0/d/F3HnW3zfj1p/29MogJINCHf0OrSA7+Pi6CaeNrEj88Q/csyY+bmns e6eIZR/T2jO/bvucp68wnefM23h/2sRHLca0RAMwtG0Z+H0h/BHg/4dAFhHgn2Xhe9rk rafeX5DGRHf1bRqrTJDVLgMgULl6rjUJSfHPza8XJqinX6Xl0rWMQUkJLCBjD0n7uZ3M wkBw== X-Gm-Message-State: ACrzQf0SMMUYUPaLHxxUDm9YXdBNwnmSG/Hb3hX5SkJQbIltRe5W9Hbn Zw68rFLwTtCzCBIr7/H7e6Q= X-Google-Smtp-Source: AMsMyM5zavXYmn5tCVy0Z2Vux3RDiHWF/OXsukshcXcM1p/L2wTbxpCxxvC3EXUZQ9dDCbE/DJ4sfw== X-Received: by 2002:a05:6a00:1a44:b0:528:6af7:ff4a with SMTP id h4-20020a056a001a4400b005286af7ff4amr20756767pfv.78.1665424145766; Mon, 10 Oct 2022 10:49:05 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o66-20020a17090a0a4800b002033b3875eesm6379203pjo.20.2022.10.10.10.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 10:49:04 -0700 (PDT) Content-Language: en-US In-Reply-To: <834jwbhawi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245036 Archived-At: This is a multi-part message in MIME format. --------------UJ3uT9uQ4viKdlQzs6aUlZ0a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/2022 9:59 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Oct 2022 09:43:55 -0700 >> Cc: 58404@debbugs.gnu.org >> From: Jim Porter >> >> Here's why I think prompting then makes sense: when you're in an >> emacsclient frame and there are other non-client frames (i.e. ones >> "owned" by the main Emacs process), that looks very similar to the user >> as when you have a second emacsclient running. > > No, there's a very fundamental difference between the two. When there > are client frames showing buffers, for each client buffer there's a > process waiting, the process which requested the buffer to be edited. > That's why we prompt: we don't want to fail those waiting processes. > > Non-client frames don't have this problem. Ok, I think that makes sense. I was hesitant about removing prompts too aggressively, since I didn't want to open users up to losing some Emacs state without prompting when they would have gotten a prompt before. However, you've convinced me that we don't need to worry about non-client frames since they don't have processes waiting on them. (Maybe some users would want more prompts in case they accidentally kill Emacs, but they can always add to 'kill-emacs-query-functions'.) Attached is a new patch that removes the prompt when called from the last remaining client. I also expanded the docstring to explain why the prompt is there. --------------UJ3uT9uQ4viKdlQzs6aUlZ0a Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYTk1YjQwOWU4OWMxZDg3MDE2YTM2YTkyMDcwYTU5MmI4YjJlNGQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLWtpbGwtZW1hY3Mt cXVlcnktZnVuY3Rpb24pOiBJZ25vcmUgdGhlCmN1cnJlbnQgY2xpZW50IChpZiBhbnkpIHdo ZW4gY2hlY2tpbmcgZm9yIGxpdmUgY2xpZW50cyAoYnVnIzU4NDA0KS4KLS0tCiBsaXNwL3Nl cnZlci5lbCB8IDE5ICsrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2VydmVy LmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uMTUxMTgwNjdlNSAxMDA2 NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1ODks MTQgKzE1ODksMTkgQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25lIChj dXJyZW50LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5LWZ1 bmN0aW9uICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxpdmUg Y2xpZW50cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3RoZXIg bGl2ZSBjbGllbnRzLgogQSBcImxpdmUgY2xpZW50XCIgaXMgYSBjbGllbnQgd2l0aCBhdCBs ZWFzdCBvbmUgbGl2ZSBidWZmZXIKLWFzc29jaWF0ZWQgd2l0aCBpdC4iCi0gIChvciAobm90 IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAgICAgICAgICAgICAgICAgICAgICAoc2Vx LXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotICAgICAgICAgICAgICAgICAgICAg c2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1vci1uby1wICJUaGlzIEVtYWNzIHNlc3Np b24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAiKSkpCithc3NvY2lhdGVkIHdpdGggaXQu ICBUaGVzZSBjbGllbnRzIHdlcmUgKHByb2JhYmx5KSBzdGFydGVkIGJ5CitleHRlcm5hbCBw cm9jZXNzZXMgdGhhdCBhcmUgd2FpdGluZyBmb3Igc29tZSBidWZmZXJzIHRvIGJlCitlZGl0 ZWQuICBJZiB0aGVyZSBhcmUgYW55IG90aGVyIGNsaWVudHMsIHdlIGRvbid0IHdhbnQgdG8g ZmFpbAordGhlaXIgd2FpdGluZyBwcm9jZXNzZXMsIHNvIGFzayB0aGUgdXNlciB0byBiZSBz dXJlLiIKKyAgKGxldCAoKHRoaXMtY2xpZW50IChmcmFtZS1wYXJhbWV0ZXIgbmlsICdjbGll bnQpKSkKKyAgICAob3IgKG5vdCAoc2VxLXNvbWUgKGxhbWJkYSAocHJvYykKKyAgICAgICAg ICAgICAgICAgICAgICAgICAodW5sZXNzIChlcSBwcm9jIHRoaXMtY2xpZW50KQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHNlcS1zb21lICMnYnVmZmVyLWxpdmUtcAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChwcm9jZXNzLWdldCBwcm9jICdidWZm ZXJzKSkpKQorICAgICAgICAgICAgICAgICAgICAgICBzZXJ2ZXItY2xpZW50cykpCisgICAg ICAgICAgKHllcy1vci1uby1wICJUaGlzIEVtYWNzIHNlc3Npb24gaGFzIG90aGVyIGNsaWVu dHM7IGV4aXQgYW55d2F5PyAiKSkpKQogCiAoZGVmdW4gc2VydmVyLWtpbGwtYnVmZmVyICgp CiAgICJSZW1vdmUgdGhlIGN1cnJlbnQgYnVmZmVyIGZyb20gaXRzIGNsaWVudHMnIGJ1ZmZl ciBsaXN0LgotLSAKMi4yNS4xCgo= --------------UJ3uT9uQ4viKdlQzs6aUlZ0a--