unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18265@debbugs.gnu.org
Subject: bug#18265: 24.3.92; lisp-completion-at-point should return nil in comments, unless after `
Date: Sat, 16 Aug 2014 05:02:21 +0400	[thread overview]
Message-ID: <53EEAD9D.5010500@yandex.ru> (raw)
In-Reply-To: <jwvy4uqhr9q.fsf-monnier+emacsbugs@gnu.org>

On 08/15/2014 04:33 PM, Stefan Monnier wrote:

> As it currently stands, there's no question that your original request
> is right (the one stated in the "Subject:"), so feel free to fix it.

Ok thanks, I will. I've been holding off on committing to trunk until I 
start using it again, but maybe it's time.

> I'm just thinking of how we could also satisfy those who might want to
> complete code-like things in comments, without having to resort
> to customization.

I've suggested one approach (in addition to seeing if there's a 
backquote before the current prefix): look if the current text is 
specially indented and separated with empty lines (though this is a very 
imprecise heurystic).

And for the cases when it's not, we can add a new completion function at 
the end of the default c-a-p-f value, which would work like 
`company-dabbrev' does. Or like `company-dabbrev-code', in `prog-mode' 
descendants. `company-capf' would ignore it, for the time being, like it 
does with `tags-completion-at-point-function' currently.

You've called ":exclusive no" a hack yourself before, and 
:merge-with-rest looks not much different to me, going counter to the 
c-a-p-f interface.

It raises questions, like if `lisp-completion-at-point' would like to be 
merged with the rest, will it be merged with all of them? Won't the 
other completion functions get a choice in the matter? What if one of 
them is smart enough to provide all completions for the current context, 
by itself?

And anyway, it doesn't seem to help with the distinction between manual 
and idle completion, unless you'd prefer to only activate the 
:merge-with-rest logic in the case of manual invocation. Which seems 
orthogonal to the property's purpose.





  reply	other threads:[~2014-08-16  1:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 12:11 bug#18265: 24.3.92; lisp-completion-at-point should return nil in comments, unless after ` Dmitry
2014-08-15  3:04 ` Stefan Monnier
2014-08-15  3:13   ` Dmitry Gutov
2014-08-15 12:33     ` Stefan Monnier
2014-08-16  1:02       ` Dmitry Gutov [this message]
2014-08-16 18:00         ` Stefan Monnier
2014-09-19  3:56           ` Dmitry Gutov
2014-09-19 14:49             ` Stefan Monnier
2014-09-19 17:45               ` Dmitry Gutov
2014-09-20  1:55                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EEAD9D.5010500@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=18265@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).