From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#18265: 24.3.92; lisp-completion-at-point should return nil in comments, unless after ` Date: Fri, 15 Aug 2014 07:13:04 +0400 Message-ID: <53ED7AC0.1050607@yandex.ru> References: <86egwjgtju.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1408072474 30209 80.91.229.3 (15 Aug 2014 03:14:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Aug 2014 03:14:34 +0000 (UTC) Cc: 18265@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 15 05:14:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XI7y8-0005nH-JX for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Aug 2014 05:14:20 +0200 Original-Received: from localhost ([::1]:57204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI7y8-00066o-2u for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Aug 2014 23:14:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI7xy-00065i-2K for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 23:14:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XI7xq-0002UM-JE for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 23:14:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI7xq-0002UI-FY for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 23:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XI7xp-0001mN-Vv for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 23:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Aug 2014 03:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18265 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18265-submit@debbugs.gnu.org id=B18265.14080723956761 (code B ref 18265); Fri, 15 Aug 2014 03:14:01 +0000 Original-Received: (at 18265) by debbugs.gnu.org; 15 Aug 2014 03:13:15 +0000 Original-Received: from localhost ([127.0.0.1]:43791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI7x4-0001kz-VQ for submit@debbugs.gnu.org; Thu, 14 Aug 2014 23:13:15 -0400 Original-Received: from mail-lb0-f172.google.com ([209.85.217.172]:52235) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI7x2-0001kl-V1 for 18265@debbugs.gnu.org; Thu, 14 Aug 2014 23:13:13 -0400 Original-Received: by mail-lb0-f172.google.com with SMTP id z11so1564650lbi.3 for <18265@debbugs.gnu.org>; Thu, 14 Aug 2014 20:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=fXodjqazbP82ZtpYBIMnJwGrIiqt5jV/AXsheVmdcR0=; b=X56CJMYyvzfFZ6f0PHjFoeV83zP5KfmrAlPmgI2VFb3yxlbgLAKRbmh7Uv9vUtYqRe QIIDLMjzDx6FfQC94/DhkGZjkGFT6Fr5lt6rm+xjC+yrq01mgBwA+mSBqNBiD231ZuuH +aZkF19Wtynp6BLQne99vXi92q3a+fLkw3TePfVPoEk9/VHD94a22HhJlhtmjo7FtaQH dNBiDUHyOD+KJhXwlcMiZ5+iu4LshoCmqHk16AhcHOiuXXz3tgkAj13fuxjP3YrVWupE EKTQr0g1/Rrdm3un5y++zm1N3sKx0jAubr8eHaYPPCSM825WjcMFwPTaLsF2oaxg4Z9h Ty9Q== X-Received: by 10.152.4.97 with SMTP id j1mr9548198laj.10.1408072386844; Thu, 14 Aug 2014 20:13:06 -0700 (PDT) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id s1sm4172895las.49.2014.08.14.20.13.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Aug 2014 20:13:05 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92478 Archived-At: On 08/15/2014 07:04 AM, Stefan Monnier wrote: > Good point. Makes me wonder how to extend completion-at-point-functions > such that a function like lisp-completion-at-point could behave > differently for something like Company (which calls it without the user > making an explicit completion request) than for an explicit M-TAB. Sometimes the user makes an explicit request, though. So it's "idle mode vs manual mode", not "Company vs complete-symbol". Still, the fact that user called `M-x company-complete' inside a comment doesn't tell me that they actually want to see completions from `company-capf' and not some other backend like `company-dabbrev'. Likewise, user pressing C-M-i inside a comment might prefer not to talk `lisp-completion-at-point', but some other completion function that goes after it that's more suited for completion in comments. If we really want to use `lisp-completion-at-point' in comments in more cases, I'd try to detect whether we're probably in a code sample (by the extra indentation, maybe), and otherwise return nil.