bug#18215: 24.4.50; OSX 10.6.8; set-frame-size by pixelwise does not work following `make-fame`.

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

 > With both Emacs versions (i.e., June 1, 2014 and the patched August 8,
 > 2014) and a setting of `(setq ns-auto-hide-menu-bar t)`, the function
 > `toggle-frame-maximized` leaves approximately 10 pixels at the top of
 > the screen that are not filled and about 4 or more pixels to the right
 > of the screen that are not filled.  The only method that I have
 > discovered that can fill the screen entirely (without going into
 > full-screen mode), is using `set-frame-size` with the pixelwise
 > argument.  When not using `(setq ns-auto-hide-menu-bar t)`, there are
 > still a few pixels that are not filled by the Emacs frame when using
 > `toggle-frame-maximized`.

I suppose the missing 10/4 pixels are from trying to constrain the size
of the frame to multiples of Emacs' character sizes.  What happens when
you disable that as in the attached patch?

martin

[-- Attachment #2: nsterm.diff --]
[-- Type: text/plain, Size: 2099 bytes --]

--- src/nsterm.m	2014-08-11 08:37:20.734375000 +0200
***************
*** 5842,5848 ****
          {
            sz.width = FRAME_COLUMN_WIDTH (emacsframe);
            sz.height = FRAME_LINE_HEIGHT (emacsframe);
!           [win setResizeIncrements: sz];
  
            NSTRACE_SIZE ("New size", NSMakeSize (neww, newh));
          }
--- 5842,5848 ----
          {
            sz.width = FRAME_COLUMN_WIDTH (emacsframe);
            sz.height = FRAME_LINE_HEIGHT (emacsframe);
! ///           [win setResizeIncrements: sz];
  
            NSTRACE_SIZE ("New size", NSMakeSize (neww, newh));
          }
***************
*** 6113,6119 ****
  
    sz.width = FRAME_COLUMN_WIDTH (f);
    sz.height = FRAME_LINE_HEIGHT (f);
!   [win setResizeIncrements: sz];
  
    [[win contentView] addSubview: self];
  
--- 6113,6119 ----
  
    sz.width = FRAME_COLUMN_WIDTH (f);
    sz.height = FRAME_LINE_HEIGHT (f);
! ///   [win setResizeIncrements: sz];
  
    [[win contentView] addSubview: self];
  
***************
*** 6499,6505 ****
        [fw setDelegate:self];
        [fw setAcceptsMouseMovedEvents: YES];
        [fw useOptimizedDrawing: YES];
!       [fw setResizeIncrements: sz];
        [fw setBackgroundColor: col];
        if ([col alphaComponent] != (EmacsCGFloat) 1.0)
          [fw setOpaque: NO];
--- 6499,6505 ----
        [fw setDelegate:self];
        [fw setAcceptsMouseMovedEvents: YES];
        [fw useOptimizedDrawing: YES];
! ///       [fw setResizeIncrements: sz];
        [fw setBackgroundColor: col];
        if ([col alphaComponent] != (EmacsCGFloat) 1.0)
          [fw setOpaque: NO];
***************
*** 6537,6543 ****
          }
  
        [w setContentView:[fw contentView]];
!       [w setResizeIncrements: sz];
        [w setBackgroundColor: col];
        if ([col alphaComponent] != (EmacsCGFloat) 1.0)
          [w setOpaque: NO];
--- 6537,6543 ----
          }
  
        [w setContentView:[fw contentView]];
! ///       [w setResizeIncrements: sz];
        [w setBackgroundColor: col];
        if ([col alphaComponent] != (EmacsCGFloat) 1.0)
          [w setOpaque: NO];